Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioContext.h

Issue 2501863003: Support for AudioContextOptions latencyHint. (Closed)
Patch Set: Updates based on reviewer comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AudioContext.h
diff --git a/third_party/WebKit/Source/modules/webaudio/AudioContext.h b/third_party/WebKit/Source/modules/webaudio/AudioContext.h
index 9187b569422e2ad46d911718852862627a46aa74..fa2f32a199420e8a896ec8dc2014f1e6435ce701 100644
--- a/third_party/WebKit/Source/modules/webaudio/AudioContext.h
+++ b/third_party/WebKit/Source/modules/webaudio/AudioContext.h
@@ -7,6 +7,7 @@
#include "bindings/core/v8/ScriptPromise.h"
#include "bindings/core/v8/ScriptPromiseResolver.h"
+#include "modules/webaudio/AudioContextOptions.h"
#include "modules/webaudio/BaseAudioContext.h"
#include "platform/heap/Handle.h"
@@ -18,11 +19,16 @@ class ScriptState;
// This is an BaseAudioContext which actually plays sound, unlike an
// OfflineAudioContext which renders sound into a buffer.
-class AudioContext : public BaseAudioContext {
+class MODULES_EXPORT AudioContext : public BaseAudioContext {
DEFINE_WRAPPERTYPEINFO();
public:
- static AudioContext* create(Document&, ExceptionState&);
+ static AudioContext* create(Document&,
+ const AudioContextOptions&,
+ ExceptionState&);
+ static AudioContext* create(Document&,
+ const WebAudioLatencyHint&,
+ ExceptionState&);
hongchan 2016/12/02 17:40:11 This is slightly confusing. Why do we need two dif
Andrew MacPherson 2016/12/05 14:12:53 Makes sense, I have refactored this down to 1 stat
~AudioContext() override;
DECLARE_VIRTUAL_TRACE();
@@ -35,8 +41,10 @@ class AudioContext : public BaseAudioContext {
bool hasRealtimeConstraint() final { return true; }
+ double baseLatency() const;
+
protected:
- AudioContext(Document&);
+ AudioContext(Document&, const WebAudioLatencyHint&);
void didClose() final;

Powered by Google App Engine
This is Rietveld 408576698