Support for AudioContextOptions latencyHint.

content/renderer/media/renderer_webaudiodevice_impl_unittest.cc

Index: content/renderer/media/renderer_webaudiodevice_impl_unittest.cc
diff --git a/content/renderer/media/renderer_webaudiodevice_impl_unittest.cc b/content/renderer/media/renderer_webaudiodevice_impl_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..e9d7717537fd62bd3c5aaf2b40166bdcdabbe9a0
--- /dev/null
+++ b/content/renderer/media/renderer_webaudiodevice_impl_unittest.cc
@@ -0,0 +1,199 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/renderer/media/renderer_webaudiodevice_impl.h"
+
+#include "base/bind.h"
+#include "base/message_loop/message_loop.h"
+#include "base/test/test_simple_task_runner.h"
+#include "build/build_config.h"
+#include "content/renderer/media/audio_device_factory.h"
+#include "media/base/audio_capturer_source.h"
+#include "media/base/mock_audio_renderer_sink.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using testing::_;
+
+namespace content {
+
+namespace {
+
+const int kHardwareSampleRate = 44100;
+const int kHardwareBufferSize = 128;
+const int kRenderFrameId = 100;
+
+int MockFrameIdFromCurrentContext() {
+  return kRenderFrameId;
+}
+
+media::AudioParameters MockGetOutputDeviceParameters(
+    int frame_id,
+    int session_id,
+    const std::string& device_id,
+    const url::Origin& security_origin) {
+  return media::AudioParameters(media::AudioParameters::AUDIO_PCM_LOW_LATENCY,
+                                media::CHANNEL_LAYOUT_STEREO,
+                                kHardwareSampleRate, 16, kHardwareBufferSize);
+}
+
+class RendererWebAudioDeviceImplUnderTest : public RendererWebAudioDeviceImpl {
+ public:
+  RendererWebAudioDeviceImplUnderTest(
+      media::ChannelLayout layout,
+      const blink::WebAudioLatencyHint& latency_hint,
+      blink::WebAudioDevice::RenderCallback* callback,
+      int session_id,
+      const url::Origin& security_origin)
+      : RendererWebAudioDeviceImpl(layout,
+                                   latency_hint,
+                                   callback,
+                                   session_id,
+                                   security_origin,
+                                   base::Bind(&MockGetOutputDeviceParameters),
+                                   base::Bind(&MockFrameIdFromCurrentContext)) {
+  }
+};
+
+}  // namespace
+
+class RendererWebAudioDeviceImplTest
+    : public blink::WebAudioDevice::RenderCallback,
+      public AudioDeviceFactory,
+      public testing::Test {
+ protected:
+  RendererWebAudioDeviceImplTest() {
+    task_runner_ = new base::TestSimpleTaskRunner();
+  }
+
+  void SetupDevice(blink::WebAudioLatencyHint latencyHint) {
+    webaudio_device_.reset(new RendererWebAudioDeviceImplUnderTest(
+        media::CHANNEL_LAYOUT_MONO, latencyHint, this, 0, url::Origin()));
+    webaudio_device_->SetMediaTaskRunnerForTesting(task_runner_);
+  }
+
+  MOCK_METHOD1(CreateAudioCapturerSource,
+               scoped_refptr<media::AudioCapturerSource>(int));
+  MOCK_METHOD4(CreateFinalAudioRendererSink,
+               scoped_refptr<media::AudioRendererSink>(int,
+                                                       int,
+                                                       const std::string&,
+                                                       const url::Origin&));
+  MOCK_METHOD5(
+      CreateSwitchableAudioRendererSink,
+      scoped_refptr<media::SwitchableAudioRendererSink>(SourceType,
+                                                        int,
+                                                        int,
+                                                        const std::string&,
+                                                        const url::Origin&));
+
+  scoped_refptr<media::AudioRendererSink> CreateAudioRendererSink(
+      SourceType source_type,
+      int render_frame_id,
+      int session_id,
+      const std::string& device_id,
+      const url::Origin& security_origin) {
+    scoped_refptr<media::MockAudioRendererSink> mock_sink =
+        new media::MockAudioRendererSink(
+            device_id, media::OUTPUT_DEVICE_STATUS_OK,
+            MockGetOutputDeviceParameters(render_frame_id, session_id,
+                                          device_id, security_origin));
+
+    EXPECT_CALL(*mock_sink.get(), Start());
+    EXPECT_CALL(*mock_sink.get(), Play());
+    EXPECT_CALL(*mock_sink.get(), Stop());
+
+    return mock_sink;
+  }
+
+  void TearDown() override { webaudio_device_.reset(); }
+
+  std::unique_ptr<RendererWebAudioDeviceImpl> webaudio_device_;
+  scoped_refptr<base::TestSimpleTaskRunner> task_runner_;
+  base::MessageLoop message_loop_;

[o1ka, 2017/02/13 08:29:30]

Why both |task_runner_| and |message_loop_| are needed? 

[Andrew MacPherson, 2017/02/13 08:52:21]

Without the MessageLoop then in the SilentSinkSuspender constructor for Android
there is a call to base::ThreadTaskRunnerHandle::Get() which was failing as the
ThreadTaskRunnerHandle isn't initialized. I looked at how other unit tests were
initializing it and it seemed to be by just instantiating a MessageLoop, but I
see what you mean now about the need for both the loop and the task_runner. I've
removed the task_runner_ now and am just using message_loop_.task_runner()
instead, does that make more sense?

+};
+
+TEST_F(RendererWebAudioDeviceImplTest, TestLatencyHintValues) {
+  blink::WebAudioLatencyHint interactiveLatencyHint(
+      blink::WebAudioLatencyHint::kCategoryInteractive);
+  int interactiveBufferSize =
+      media::AudioLatency::GetInteractiveBufferSize(kHardwareBufferSize);
+  SetupDevice(interactiveLatencyHint);
+
+  EXPECT_EQ(webaudio_device_->sampleRate(), kHardwareSampleRate);
+  EXPECT_EQ(webaudio_device_->framesPerBuffer(), interactiveBufferSize);
+
+  webaudio_device_->start();
+  EXPECT_EQ(webaudio_device_->sampleRate(), kHardwareSampleRate);
+  EXPECT_EQ(webaudio_device_->framesPerBuffer(), interactiveBufferSize);
+
+  webaudio_device_->stop();
+  EXPECT_EQ(webaudio_device_->sampleRate(), kHardwareSampleRate);
+  EXPECT_EQ(webaudio_device_->framesPerBuffer(), interactiveBufferSize);
+
+  webaudio_device_->start();
+  EXPECT_EQ(webaudio_device_->sampleRate(), kHardwareSampleRate);
+  EXPECT_EQ(webaudio_device_->framesPerBuffer(), interactiveBufferSize);
+
+  webaudio_device_->stop();
+  EXPECT_EQ(webaudio_device_->sampleRate(), kHardwareSampleRate);
+  EXPECT_EQ(webaudio_device_->framesPerBuffer(), interactiveBufferSize);
+
+  blink::WebAudioLatencyHint balancedLatencyHint(
+      blink::WebAudioLatencyHint::kCategoryBalanced);
+  int balancedBufferSize = media::AudioLatency::GetRtcBufferSize(
+      kHardwareSampleRate, kHardwareBufferSize);
+  SetupDevice(balancedLatencyHint);
+
+  EXPECT_EQ(webaudio_device_->sampleRate(), kHardwareSampleRate);
+  EXPECT_EQ(webaudio_device_->framesPerBuffer(), balancedBufferSize);
+
+  webaudio_device_->start();
+  EXPECT_EQ(webaudio_device_->sampleRate(), kHardwareSampleRate);
+  EXPECT_EQ(webaudio_device_->framesPerBuffer(), balancedBufferSize);
+
+  webaudio_device_->stop();
+  EXPECT_EQ(webaudio_device_->sampleRate(), kHardwareSampleRate);
+  EXPECT_EQ(webaudio_device_->framesPerBuffer(), balancedBufferSize);
+
+  webaudio_device_->start();
+  EXPECT_EQ(webaudio_device_->sampleRate(), kHardwareSampleRate);
+  EXPECT_EQ(webaudio_device_->framesPerBuffer(), balancedBufferSize);
+
+  webaudio_device_->stop();
+  EXPECT_EQ(webaudio_device_->sampleRate(), kHardwareSampleRate);
+  EXPECT_EQ(webaudio_device_->framesPerBuffer(), balancedBufferSize);
+
+  blink::WebAudioLatencyHint playbackLatencyHint(
+      blink::WebAudioLatencyHint::kCategoryPlayback);
+  int playbackBufferSize =
+      media::AudioLatency::GetHighLatencyBufferSize(kHardwareSampleRate, 0);
+  SetupDevice(playbackLatencyHint);
+
+  EXPECT_EQ(webaudio_device_->sampleRate(), kHardwareSampleRate);
+  EXPECT_EQ(webaudio_device_->framesPerBuffer(), playbackBufferSize);
+
+  webaudio_device_->start();
+  EXPECT_EQ(webaudio_device_->sampleRate(), kHardwareSampleRate);
+  EXPECT_EQ(webaudio_device_->framesPerBuffer(), playbackBufferSize);
+
+  webaudio_device_->stop();
+  EXPECT_EQ(webaudio_device_->sampleRate(), kHardwareSampleRate);
+  EXPECT_EQ(webaudio_device_->framesPerBuffer(), playbackBufferSize);
+
+  webaudio_device_->start();
+  EXPECT_EQ(webaudio_device_->sampleRate(), kHardwareSampleRate);
+  EXPECT_EQ(webaudio_device_->framesPerBuffer(), playbackBufferSize);
+
+  webaudio_device_->stop();
+  EXPECT_EQ(webaudio_device_->sampleRate(), kHardwareSampleRate);
+  EXPECT_EQ(webaudio_device_->framesPerBuffer(), playbackBufferSize);
+
+#if !defined(OS_ANDROID)
+  EXPECT_GE(playbackBufferSize, balancedBufferSize);
+  EXPECT_GE(balancedBufferSize, interactiveBufferSize);
+#endif
+}
+
+}  // namespace content