third_party/WebKit/Source/modules/webaudio/AudioContextOptions.idl - Issue 2501863003: Support for AudioContextOptions latencyHint.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/webaudio/AudioContextOptions.idl

Issue 2501863003: Support for AudioContextOptions latencyHint. (Closed)

Patch Set: Add baseLatency and fix use of hardwareSampleRate. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // See https://webaudio.github.io/web-audio-api/#audiocontextoptions

	6 dictionary AudioContextOptions {

	7 AudioContextLatencyCategory latencyHint = "interactive";
	Raymond Toy 2016/11/30 21:50:27 Although you're not implementing the double value Although you're not implementing the double value part yet, I think we should define this correctly now instead of later. For the implementation, we can just treat float value as being the same as interactive, until it's supported. WDYT? Andrew MacPherson 2016/12/01 12:11:56 Makes sense, I have added this now though I had to Show quoted text On 2016/11/30 21:50:27, Raymond Toy wrote: > Although you're not implementing the double value part yet, I think we should > define this correctly now instead of later. For the implementation, we can just > treat float value as being the same as interactive, until it's supported. > > WDYT? Makes sense, I have added this now though I had to add an unnecessary typedef for the type as it didn't seem to generate the AudioContextLatencyCategoryOrDouble otherwise. I looked at other examples of this kind of thing to figure out the typedef workaround.
	8 };

OLD	NEW