third_party/WebKit/Source/modules/webaudio/AudioContextOptions.idl - Issue 2501863003: Support for AudioContextOptions latencyHint.

Side by Side Diff: third_party/WebKit/Source/modules/webaudio/AudioContextOptions.idl

Issue 2501863003: Support for AudioContextOptions latencyHint. (Closed)

Patch Set: Check all LatencyHints WebAudioDeviceImpl test. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« third_party/WebKit/LayoutTests/webaudio/audiocontextoptions.html ('K') | « third_party/WebKit/Source/modules/webaudio/AudioContext.idl ('k') | third_party/WebKit/Source/modules/webaudio/AudioContextTest.cpp » ('j') | third_party/WebKit/Source/modules/webaudio/AudioDestinationNode.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 typedef (AudioContextLatencyCategory or double) LatencyHint;

	6

	7 // See https://webaudio.github.io/web-audio-api/#audiocontextoptions

	8 dictionary AudioContextOptions {

	9 LatencyHint latencyHint = "interactive";
	Raymond Toy 2016/12/08 17:14:38 Does this introduce LatencyHint into the global na Does this introduce LatencyHint into the global namespace? If so, that's probably not something we want. Andrew MacPherson 2016/12/09 12:34:14 I believe it does. I've renamed it to AudioContext Show quoted text On 2016/12/08 17:14:38, Raymond Toy wrote: > Does this introduce LatencyHint into the global namespace? If so, that's > probably not something we want. I believe it does. I've renamed it to AudioContextLatencyHint, does that work? hongchan@ mentioned in a previous comment that having this typedef is the way to ensure that the AudioContextLatencyCategoryOrDouble type is generated properly. Raymond Toy 2016/12/13 15:53:11 That would be unfortunate, I think. In my origina Show quoted text On 2016/12/09 12:34:14, Andrew MacPherson wrote: > On 2016/12/08 17:14:38, Raymond Toy wrote: > > Does this introduce LatencyHint into the global namespace? If so, that's > > probably not something we want. > > I believe it does. I've renamed it to AudioContextLatencyHint, does that work? > hongchan@ mentioned in a previous comment that having this typedef is the way to > ensure that the AudioContextLatencyCategoryOrDouble type is generated properly. That would be unfortunate, I think. In my original CL, I don't think I had to to this. AudioContextLatencyCategoryOrDouble was defined in the C++ code, eventually. I don't remember what I had to do to make this happen. Or maybe I'm just wrong. Andrew MacPherson 2016/12/14 09:07:20 The original CL doesn't compile but I took another Show quoted text On 2016/12/13 15:53:11, Raymond Toy wrote: > On 2016/12/09 12:34:14, Andrew MacPherson wrote: > > On 2016/12/08 17:14:38, Raymond Toy wrote: > > > Does this introduce LatencyHint into the global namespace? If so, that's > > > probably not something we want. > > > > I believe it does. I've renamed it to AudioContextLatencyHint, does that work? > > hongchan@ mentioned in a previous comment that having this typedef is the way > to > > ensure that the AudioContextLatencyCategoryOrDouble type is generated > properly. > > That would be unfortunate, I think. In my original CL, I don't think I had to > to this. AudioContextLatencyCategoryOrDouble was defined in the C++ code, > eventually. I don't > remember what I had to do to make this happen. Or maybe I'm just wrong. The original CL doesn't compile but I took another look here and you're right that the typedef is not needed. This was my mistake, the part I believe I was missing was that the type's .cpp/.h files needed to be included in Source/bindings/modules/v8/generated.gni (they are now but weren't when I was first looking at this). I've removed the typedef now, thanks!
	10 };

OLD	NEW