Simplifies the blocking file lock test

Simplifies the blocking file lock test

This test is complicated and times out flakily. This CL simplifies the test.
There is one place it may still have flakey timeouts, which I'll address if
it happens in practice.

related #27456

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/d5466b0c926106daf0f4928262953be6820f3ff2

[zra, 2016-11-15 00:03:52]

Description was changed from

==========
Simplifies the blocking file lock test
==========

to

==========
Simplifies the blocking file lock test

This test is complicated and times out flakily. This CL simplifies the test.
There is one place it may still have flakey timeouts, which I'll address if
it happens in practice.

related #27456
==========

[zra, 2016-11-15 00:04:11]

zra@google.com changed reviewers:
+ johnmccutchan@google.com

[zra, 2016-11-15 17:40:50]

zra@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2016-11-15 17:54:49]

lgtm

https://codereview.chromium.org/2501803002/diff/1/tests/standalone/io/file_bl...
File tests/standalone/io/file_blocking_lock_test.dart (right):

https://codereview.chromium.org/2501803002/diff/1/tests/standalone/io/file_bl...
tests/standalone/io/file_blocking_lock_test.dart:55: } catch(e) {
nit: Should e be expected to be a specific exception? Otherwise, If e is not
needed you can shorten to:

try { ... } on dynamic { ... }

https://codereview.chromium.org/2501803002/diff/1/tests/standalone/io/file_bl...
tests/standalone/io/file_blocking_lock_test.dart:87: await
peer.exitCode.then((v) async {
Can this be shortened?

var v = await peer.exitCode;
Expect.equals(0, v);
...

[zra, 2016-11-15 18:23:58]

https://codereview.chromium.org/2501803002/diff/1/tests/standalone/io/file_bl...
File tests/standalone/io/file_blocking_lock_test.dart (right):

https://codereview.chromium.org/2501803002/diff/1/tests/standalone/io/file_bl...
tests/standalone/io/file_blocking_lock_test.dart:55: } catch(e) {
On 2016/11/15 17:54:49, Florian Schneider wrote:
> nit: Should e be expected to be a specific exception? Otherwise, If e is not
> needed you can shorten to:
> 
> try { ... } on dynamic { ... }

Done.

https://codereview.chromium.org/2501803002/diff/1/tests/standalone/io/file_bl...
tests/standalone/io/file_blocking_lock_test.dart:87: await
peer.exitCode.then((v) async {
On 2016/11/15 17:54:49, Florian Schneider wrote:
> Can this be shortened?
> 
> var v = await peer.exitCode;
> Expect.equals(0, v);
> ...

Done.

[zra, 2016-11-15 18:24:08]

Description was changed from

==========
Simplifies the blocking file lock test

This test is complicated and times out flakily. This CL simplifies the test.
There is one place it may still have flakey timeouts, which I'll address if
it happens in practice.

related #27456
==========

to

==========
Simplifies the blocking file lock test

This test is complicated and times out flakily. This CL simplifies the test.
There is one place it may still have flakey timeouts, which I'll address if
it happens in practice.

related #27456

R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d5466b0c926106daf0f4928262953be6820f3ff2
==========

[zra, 2016-11-15 18:24:10]

Committed patchset #2 (id:20001) manually as
d5466b0c926106daf0f4928262953be6820f3ff2 (presubmit successful).