MD Settings: Hook up import data dialog.

chrome/browser/resources/settings/people_page/import_data_dialog.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview 'settings-import-data-dialog' is a component for importing
  * bookmarks and other data from other sources.
  */
 Polymer({
   is: 'settings-import-data-dialog',
 
   behaviors: [I18nBehavior, WebUIListenerBehavior],
 
   properties: {
     /** @private {!Array<!settings.BrowserProfile>} */
     browserProfiles_: Array,
 
     /** @private {!settings.BrowserProfile} */
     selected_: Object,
 
+    /**
+     * Whether none of the import data categories is selected.
+     * @private
+     */
+    noImportDataTypeSelected_: {
+      type: Boolean,
+      value: false,
+    },
+
     prefs: Object,
+
+    /** @private */
+    importStatus_: {
+      type: String,
+      value: settings.ImportDataStatus.INITIAL,
+    },
+
+    /**
+     * Mirroring the enum so that it can be used from HTML bindings.
+     * @private
+     */
+    importStatusEnum_: {
+      type: Object,
+      value: settings.ImportDataStatus,
+    },
   },
 
+  observers: [
+    'prefsChanged_(selected_, prefs.*)',
+  ],
+
   /** @private {?settings.ImportDataBrowserProxy} */
   browserProxy_: null,
 
   /** @override */
   attached: function() {
     this.browserProxy_ = settings.ImportDataBrowserProxyImpl.getInstance();
-    this.browserProxy_.initializeImportDialog().then(function(data) {
-      this.browserProfiles_ = data;
-      this.selected_ = this.browserProfiles_[0];
-    }.bind(this));
+    this.browserProxy_.initializeImportDialog().then(
+        /** @param {!Array<!settings.BrowserProfile>} data */
+        function(data) {
+          this.browserProfiles_ = data;
+          this.selected_ = this.browserProfiles_[0];
+        }.bind(this));
 
-    this.addWebUIListener('import-data-status-changed', function(e) {
-      // TODO(dpapad): Handle events to show spinner or success message.
-    });
+    this.addWebUIListener(
+        'import-data-status-changed',
+        /** @param {settings.ImportDataStatus} importStatus */
+        function(importStatus) {
+          this.importStatus_ = importStatus;
+          if (this.hasImportStatus_(settings.ImportDataStatus.FAILED))
+            this.closeDialog_();
+        }.bind(this));
 
     this.$.dialog.showModal();
   },
 
   /** @private */
+  prefsChanged_() {
+    this.noImportDataTypeSelected_ =
+        !(this.prefs['import_history'].value && this.selected_.history) &&

[dpapad, 2016/11/16 21:33:02]

Is it OK to access prefs this way? Or should I be using PrefsBehavior methods
instead?

[tommycli, 2016/11/16 21:43:40]

I bet it's harmless to do it this way, but I'd still recommend using
PrefsBehavior unless we're sure we really can't afford to add the behavior...

Just for cleanliness

[Dan Beam, 2016/11/16 21:45:15]

wont compile, .get('prefs.import_history.value') will though ;)

[dpapad, 2016/11/16 21:47:10]

Tried this locally and compiled. If I remove the quote notation it doesn't
though. I'll try the behavior in a sec.

[dpapad, 2016/11/16 21:54:08]

Using PrefsBehavior in latest patch.

+        !(this.prefs['import_bookmarks'].value && this.selected_.favorites) &&
+        !(this.prefs['import_saved_passwords'].value &&
+            this.selected_.passwords) &&
+        !(this.prefs['import_search_engine'].value && this.selected_.search) &&
+        !(this.prefs['import_autofill_form_data'].value &&
+            this.selected_.autofillFormData);
+  },
+
+  /**
+   * @param {!settings.ImportDataStatus} status
+   * @return {boolean} Whether |status| is the current status.
+   * @private
+   */
+  hasImportStatus_: function(status) {
+    return this.importStatus_ == status;
+  },
+
+  /** @private */
   isImportFromFileSelected_: function() {
     // The last entry in |browserProfiles_| always refers to dummy profile for
     // importing from a bookmarks file.
     return this.selected_.index == this.browserProfiles_.length - 1;
   },
 
   /**
    * @return {string}
    * @private
    */
   getActionButtonText_: function() {
     return this.i18n(this.isImportFromFileSelected_() ?
         'importChooseFile' : 'importCommit');
   },
 
   /** @private */
-  onChange_: function() {
+  onBrowserProfileSelectiChange_: function() {

[tommycli, 2016/11/16 21:43:40]

Same typo here, so I guess that's why it works?

[dpapad, 2016/11/16 21:47:10]

Already fixed.

     this.selected_ = this.browserProfiles_[this.$.browserSelect.selectedIndex];
   },
 
   /** @private */
   onActionButtonTap_: function() {
-    if (this.isImportFromFileSelected_()) {
+    if (this.isImportFromFileSelected_())
       this.browserProxy_.importFromBookmarksFile();
-    } else {
-      // TODO(dpapad): Implement this.
-    }
+    else
+      this.browserProxy_.importData(this.$.browserSelect.selectedIndex);
   },
 
   /** @private */
-  onCancelTap_: function() {
+  closeDialog_: function() {
     this.$.dialog.close();
   },
+
+  /**
+   * @return {boolean} Whether the import button should be disabled.
+   * @private
+   */
+  shouldDisableImport_: function() {
+    return this.hasImportStatus_(settings.ImportDataStatus.IN_PROGRESS) ||
+        this.noImportDataTypeSelected_;
+  },
 });