set WM_CLASS in X11 window host.

set WM_CLASS in X11 window host.

X11 chromium os window misses the WM_CLASS property, which makes
developing / testing it with tiling window manager a little bit
painful that there is no way to specify rules for such window.
This CL aims to fix this issue.

Test=Chromium window opens with WM_CLASS property.

BUG=665654
Committed: https://crrev.com/dbec25ee5e2a59c5e5fd6fa24c7757f98155cbc7
Cr-Commit-Position: refs/heads/master@{#432357}

[Muyuan, 2016-11-16 00:21:33]

muyuanli@chromium.org changed reviewers:
+ sadrul@chromium.org, sky@chromium.org, xiaohuic@chromium.org,
xiyuan@chromium.org

[xc, 2016-11-16 00:26:57]

lgtm

[sadrul, 2016-11-16 00:29:45]

https://codereview.chromium.org/2501763005/diff/1/ui/aura/window_tree_host_x1...
File ui/aura/window_tree_host_x11.cc (right):

https://codereview.chromium.org/2501763005/diff/1/ui/aura/window_tree_host_x1...
ui/aura/window_tree_host_x11.cc:167: XFree(class_hint);
Can you use ui::SetWindowClassHint() instead?

[Muyuan, 2016-11-16 00:51:43]

https://codereview.chromium.org/2501763005/diff/1/ui/aura/window_tree_host_x1...
File ui/aura/window_tree_host_x11.cc (right):

https://codereview.chromium.org/2501763005/diff/1/ui/aura/window_tree_host_x1...
ui/aura/window_tree_host_x11.cc:167: XFree(class_hint);
On 2016/11/16 00:29:44, sadrul wrote:
> Can you use ui::SetWindowClassHint() instead?

Done.

[Muyuan, 2016-11-16 00:51:55]

The CQ bit was checked by muyuanli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 00:52:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-11-16 01:25:21]

lgtm

[commit-bot: I haz the power, 2016-11-16 02:01:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 02:01:41]

Dry run: This issue passed the CQ dry run.

[Muyuan, 2016-11-16 02:12:48]

The CQ bit was checked by muyuanli@chromium.org

[Muyuan, 2016-11-16 02:12:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
xiaohuic@chromium.org
Link to the patchset: https://codereview.chromium.org/2501763005/#ps20001
(title: "Use ui::SetWindowClassHint instead.")

[commit-bot: I haz the power, 2016-11-16 02:13:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 02:18:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-16 02:25:05]

Description was changed from

==========
set WM_CLASS in X11 window host.

X11 chromium os window misses the WM_CLASS property, which makes
developing / testing it with tiling window manager a little bit
painful that there is no way to specify rules for such window.
This CL aims to fix this issue.

Test=Chromium window opens with WM_CLASS property.

BUG=665654
==========

to

==========
set WM_CLASS in X11 window host.

X11 chromium os window misses the WM_CLASS property, which makes
developing / testing it with tiling window manager a little bit
painful that there is no way to specify rules for such window.
This CL aims to fix this issue.

Test=Chromium window opens with WM_CLASS property.

BUG=665654

Committed: https://crrev.com/dbec25ee5e2a59c5e5fd6fa24c7757f98155cbc7
Cr-Commit-Position: refs/heads/master@{#432357}
==========

[commit-bot: I haz the power, 2016-11-16 02:25:06]

Patchset 2 (id:??) landed as
https://crrev.com/dbec25ee5e2a59c5e5fd6fa24c7757f98155cbc7
Cr-Commit-Position: refs/heads/master@{#432357}