Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 2501763003: Remove fullscreen from MD Settings internal lists. (Closed)

Created:
4 years, 1 month ago by Matt Giuca
Modified:
4 years, 1 month ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove fullscreen from MD Settings internal lists. This fixes a crash when opening All Sites as well as on some other pages, due to fullscreen still being registered as a content setting in some lists despite it having been removed from content settings in r431465. BUG=664886, 664905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/7cd995297b9948b436e3d7a1656cef284a812bfe Cr-Commit-Position: refs/heads/master@{#432319}

Patch Set 1 #

Patch Set 2 : Fixed tests. #

Messages

Total messages: 17 (12 generated)
Matt Giuca
See bug report.
4 years, 1 month ago (2016-11-15 04:32:13 UTC) #5
dschuyler
lgtm
4 years, 1 month ago (2016-11-15 21:36:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501763003/20001
4 years, 1 month ago (2016-11-15 23:52:34 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-16 00:35:47 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 00:37:32 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7cd995297b9948b436e3d7a1656cef284a812bfe
Cr-Commit-Position: refs/heads/master@{#432319}

Powered by Google App Engine
This is Rietveld 408576698