Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2501753002: [Mac] Changes for the security chip (Closed)

Created:
4 years, 1 month ago by spqchan
Modified:
4 years, 1 month ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Changes for the security chip - Decoration should now animate out if it's no longer shown - Fix the logic so that the chip will animate in when the tab has changed BUG=662666 Committed: https://crrev.com/2d4901746d188f60327a85ae807bad0429810da5 Cr-Commit-Position: refs/heads/master@{#432346}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -23 lines) Patch
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 3 chunks +31 lines, -23 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
spqchan
PTAL
4 years, 1 month ago (2016-11-15 02:02:03 UTC) #4
Robert Sesek
lgtm
4 years, 1 month ago (2016-11-15 19:05:08 UTC) #5
spqchan
On 2016/11/15 19:05:08, Robert Sesek wrote: > lgtm thanks!
4 years, 1 month ago (2016-11-15 19:06:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501753002/1
4 years, 1 month ago (2016-11-15 19:07:14 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/260827)
4 years, 1 month ago (2016-11-15 19:24:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501753002/1
4 years, 1 month ago (2016-11-15 23:21:17 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/261380)
4 years, 1 month ago (2016-11-15 23:46:50 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501753002/1
4 years, 1 month ago (2016-11-16 01:22:09 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 01:38:15 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 01:43:41 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d4901746d188f60327a85ae807bad0429810da5
Cr-Commit-Position: refs/heads/master@{#432346}

Powered by Google App Engine
This is Rietveld 408576698