Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 2501723003: Disable scrollbars on the root scroller when using visual viewport scrollbars. (Closed)
Patch Set: Fix (?) Graphics2D test Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ppapi/tests/test_graphics_2d.cc ('k') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights
8 reserved. 8 reserved.
9 9
10 This library is free software; you can redistribute it and/or 10 This library is free software; you can redistribute it and/or
(...skipping 749 matching lines...) Expand 10 before | Expand all | Expand 10 after
760 bool scrollContentsFastPath(const IntSize& scrollDelta); 760 bool scrollContentsFastPath(const IntSize& scrollDelta);
761 761
762 // Scroll the content by invalidating everything. 762 // Scroll the content by invalidating everything.
763 void scrollContentsSlowPath(); 763 void scrollContentsSlowPath();
764 764
765 ScrollBehavior scrollBehaviorStyle() const override; 765 ScrollBehavior scrollBehaviorStyle() const override;
766 766
767 void scrollContentsIfNeeded(); 767 void scrollContentsIfNeeded();
768 768
769 enum ComputeScrollbarExistenceOption { FirstPass, Incremental }; 769 enum ComputeScrollbarExistenceOption { FirstPass, Incremental };
770 void computeScrollbarExistence( 770 void computeScrollbarExistence(bool& newHasHorizontalScrollbar,
771 bool& newHasHorizontalScrollbar, 771 bool& newHasVerticalScrollbar,
772 bool& newHasVerticalScrollbar, 772 const IntSize& docSize,
773 const IntSize& docSize, 773 ComputeScrollbarExistenceOption = FirstPass);
774 ComputeScrollbarExistenceOption = FirstPass) const;
775 void updateScrollbarGeometry(); 774 void updateScrollbarGeometry();
776 775
777 // Called to update the scrollbars to accurately reflect the state of the 776 // Called to update the scrollbars to accurately reflect the state of the
778 // view. 777 // view.
779 void updateScrollbars(); 778 void updateScrollbars();
780 void updateScrollbarsIfNeeded(); 779 void updateScrollbarsIfNeeded();
781 780
782 class InUpdateScrollbarsScope { 781 class InUpdateScrollbarsScope {
783 STACK_ALLOCATED(); 782 STACK_ALLOCATED();
784 783
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
859 void contentsResized() override; 858 void contentsResized() override;
860 void scrollbarExistenceDidChange(); 859 void scrollbarExistenceDidChange();
861 860
862 // Override Widget methods to do point conversion via layoutObjects, in order 861 // Override Widget methods to do point conversion via layoutObjects, in order
863 // to take transforms into account. 862 // to take transforms into account.
864 IntRect convertToContainingWidget(const IntRect&) const override; 863 IntRect convertToContainingWidget(const IntRect&) const override;
865 IntRect convertFromContainingWidget(const IntRect&) const override; 864 IntRect convertFromContainingWidget(const IntRect&) const override;
866 IntPoint convertToContainingWidget(const IntPoint&) const override; 865 IntPoint convertToContainingWidget(const IntPoint&) const override;
867 IntPoint convertFromContainingWidget(const IntPoint&) const override; 866 IntPoint convertFromContainingWidget(const IntPoint&) const override;
868 867
868 void didChangeGlobalRootScroller() override;
869
869 void updateWidgetGeometriesIfNeeded(); 870 void updateWidgetGeometriesIfNeeded();
870 871
871 bool wasViewportResized(); 872 bool wasViewportResized();
872 void sendResizeEventIfNeeded(); 873 void sendResizeEventIfNeeded();
873 874
874 void updateParentScrollableAreaSet(); 875 void updateParentScrollableAreaSet();
875 876
876 void scheduleUpdateWidgetsIfNecessary(); 877 void scheduleUpdateWidgetsIfNecessary();
877 void updateWidgetsTimerFired(TimerBase*); 878 void updateWidgetsTimerFired(TimerBase*);
878 bool updateWidgets(); 879 bool updateWidgets();
(...skipping 27 matching lines...) Expand all
906 907
907 void updateScrollCorner(); 908 void updateScrollCorner();
908 909
909 AXObjectCache* axObjectCache() const; 910 AXObjectCache* axObjectCache() const;
910 911
911 void setLayoutSizeInternal(const IntSize&); 912 void setLayoutSizeInternal(const IntSize&);
912 913
913 bool adjustScrollbarExistence(ComputeScrollbarExistenceOption = FirstPass); 914 bool adjustScrollbarExistence(ComputeScrollbarExistenceOption = FirstPass);
914 void adjustScrollbarOpacity(); 915 void adjustScrollbarOpacity();
915 void adjustScrollOffsetFromUpdateScrollbars(); 916 void adjustScrollOffsetFromUpdateScrollbars();
916 bool visualViewportSuppliesScrollbars() const; 917 bool visualViewportSuppliesScrollbars();
917 918
918 bool isFrameViewScrollbar(const Widget* child) const { 919 bool isFrameViewScrollbar(const Widget* child) const {
919 return horizontalScrollbar() == child || verticalScrollbar() == child; 920 return horizontalScrollbar() == child || verticalScrollbar() == child;
920 } 921 }
921 922
922 ScrollingCoordinator* scrollingCoordinator() const; 923 ScrollingCoordinator* scrollingCoordinator() const;
923 924
924 void prepareLayoutAnalyzer(); 925 void prepareLayoutAnalyzer();
925 std::unique_ptr<TracedValue> analyzerCounters(); 926 std::unique_ptr<TracedValue> analyzerCounters();
926 927
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
1148 widget.isFrameView()); 1149 widget.isFrameView());
1149 DEFINE_TYPE_CASTS(FrameView, 1150 DEFINE_TYPE_CASTS(FrameView,
1150 ScrollableArea, 1151 ScrollableArea,
1151 scrollableArea, 1152 scrollableArea,
1152 scrollableArea->isFrameView(), 1153 scrollableArea->isFrameView(),
1153 scrollableArea.isFrameView()); 1154 scrollableArea.isFrameView());
1154 1155
1155 } // namespace blink 1156 } // namespace blink
1156 1157
1157 #endif // FrameView_h 1158 #endif // FrameView_h
OLDNEW
« no previous file with comments | « ppapi/tests/test_graphics_2d.cc ('k') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698