Disable scrollbars on the root scroller when using visual viewport scrollbars.

third_party/WebKit/Source/core/frame/FrameView.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Dirk Mueller <mueller@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *           (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
@@ skipping 71 matching lines @@
 #include "core/layout/svg/LayoutSVGRoot.h"
 #include "core/loader/DocumentLoader.h"
 #include "core/loader/FrameLoader.h"
 #include "core/loader/FrameLoaderClient.h"
 #include "core/observer/ResizeObserverController.h"
 #include "core/page/AutoscrollController.h"
 #include "core/page/ChromeClient.h"
 #include "core/page/FocusController.h"
 #include "core/page/FrameTree.h"
 #include "core/page/Page.h"
+#include "core/page/scrolling/RootScrollerUtil.h"
 #include "core/page/scrolling/ScrollingCoordinator.h"
 #include "core/page/scrolling/TopDocumentRootScrollerController.h"
 #include "core/paint/FramePainter.h"
 #include "core/paint/PaintLayer.h"
 #include "core/paint/PrePaintTreeWalk.h"
 #include "core/plugins/PluginView.h"
 #include "core/style/ComputedStyle.h"
 #include "core/svg/SVGDocumentExtensions.h"
 #include "core/svg/SVGSVGElement.h"
 #include "platform/Histogram.h"
@@ skipping 1858 matching lines @@
 
 void FrameView::scrollbarExistenceDidChange() {
   // We check to make sure the view is attached to a frame() as this method can
   // be triggered before the view is attached by LocalFrame::createView(...)
   // setting various values such as setScrollBarModes(...) for example.  An
   // ASSERT is triggered when a view is layout before being attached to a
   // frame().
   if (!frame().view())
     return;
 
-  bool hasOverlayScrollbars = this->hasOverlayScrollbars();
+  bool usesOverlayScrollbars = ScrollbarTheme::theme().usesOverlayScrollbars();
 
   // FIXME: this call to layout() could be called within FrameView::layout(),
   // but before performLayout(), causing double-layout. See also
   // crbug.com/429242.
-  if (!hasOverlayScrollbars && needsLayout())
+  if (!usesOverlayScrollbars && needsLayout())
     layout();
 
   if (!layoutViewItem().isNull() && layoutViewItem().usesCompositing()) {
     layoutViewItem().compositor()->frameViewScrollbarsExistenceDidChange();
 
-    if (!hasOverlayScrollbars)
+    if (!usesOverlayScrollbars)
       layoutViewItem().compositor()->frameViewDidChangeSize();
   }
 }
 
 void FrameView::handleLoadCompleted() {
   // Once loading has completed, allow autoSize one last opportunity to
   // reduce the size of the frame.
   if (m_autoSizeInfo)
     m_autoSizeInfo->autoSizeIfNeeded();
 
@@ skipping 668 matching lines @@
   if (!parent())
     return nullptr;
 
   Frame* parentFrame = m_frame->tree().parent();
   if (parentFrame && parentFrame->isLocalFrame())
     return toLocalFrame(parentFrame)->view();
 
   return nullptr;
 }
 
+void FrameView::didChangeGlobalRootScroller() {
+  if (!m_frame->settings() || !m_frame->settings()->viewportEnabled())
+    return;
+
+  // Avoid drawing two sets of scrollbars when visual viewport is enabled.
+  bool hasHorizontalScrollbar = horizontalScrollbar();
+  bool hasVerticalScrollbar = verticalScrollbar();
+  bool shouldHaveHorizontalScrollbar = false;
+  bool shouldHaveVerticalScrollbar = false;
+  computeScrollbarExistence(shouldHaveHorizontalScrollbar,
+                            shouldHaveVerticalScrollbar, contentsSize());
+  m_scrollbarManager.setHasHorizontalScrollbar(shouldHaveHorizontalScrollbar);
+  m_scrollbarManager.setHasVerticalScrollbar(shouldHaveVerticalScrollbar);
+
+  if (hasHorizontalScrollbar != shouldHaveHorizontalScrollbar ||
+      hasVerticalScrollbar != shouldHaveVerticalScrollbar)
+    scrollbarExistenceDidChange();
+}
+
 void FrameView::updateWidgetGeometriesIfNeeded() {
   if (!m_needsUpdateWidgetGeometries)
     return;
 
   m_needsUpdateWidgetGeometries = false;
 
   updateWidgetGeometries();
 }
 
 void FrameView::updateAllLifecyclePhases() {
@@ skipping 804 matching lines @@
 void FrameView::removeChild(Widget* child) {
   ASSERT(child->parent() == this);
 
   if (child->isFrameView())
     removeScrollableArea(toFrameView(child));
 
   child->setParent(0);
   m_children.remove(child);
 }
 
-bool FrameView::visualViewportSuppliesScrollbars() const {
-  return m_frame->isMainFrame() && m_frame->settings() &&
-         m_frame->settings()->viewportEnabled();
+bool FrameView::visualViewportSuppliesScrollbars() {
+  // On desktop, we always use the layout viewport's scrollbars.
+  if (!m_frame->settings() || !m_frame->settings()->viewportEnabled() ||
+      !m_frame->document() || !m_frame->host())
+    return false;
+
+  const TopDocumentRootScrollerController& controller =
+      m_frame->host()->globalRootScrollerController();
+
+  if (!controller.globalRootScroller())
+    return false;
+
+  return RootScrollerUtil::scrollableAreaFor(
+             *controller.globalRootScroller()) ==
+         layoutViewportScrollableArea();
 }
 
 AXObjectCache* FrameView::axObjectCache() const {
   if (frame().document())
     return frame().document()->existingAXObjectCache();
   return nullptr;
 }
 
 void FrameView::setCursor(const Cursor& cursor) {
   Page* page = frame().page();
@@ skipping 228 matching lines @@
 bool FrameView::hasOverlayScrollbars() const {
   return (horizontalScrollbar() &&
           horizontalScrollbar()->isOverlayScrollbar()) ||
          (verticalScrollbar() && verticalScrollbar()->isOverlayScrollbar());
 }
 
 void FrameView::computeScrollbarExistence(
     bool& newHasHorizontalScrollbar,
     bool& newHasVerticalScrollbar,
     const IntSize& docSize,
-    ComputeScrollbarExistenceOption option) const {
-  if (m_frame->settings() && m_frame->settings()->hideScrollbars()) {
+    ComputeScrollbarExistenceOption option) {
+  if ((m_frame->settings() && m_frame->settings()->hideScrollbars()) ||
+      visualViewportSuppliesScrollbars()) {
     newHasHorizontalScrollbar = false;
     newHasVerticalScrollbar = false;
     return;
   }
 
   bool hasHorizontalScrollbar = horizontalScrollbar();
   bool hasVerticalScrollbar = verticalScrollbar();
 
   newHasHorizontalScrollbar = hasHorizontalScrollbar;
   newHasVerticalScrollbar = hasVerticalScrollbar;
@@ skipping 828 matching lines @@
   DCHECK(m_frame->isMainFrame());
   return m_initialViewportSize.width();
 }
 
 int FrameView::initialViewportHeight() const {
   DCHECK(m_frame->isMainFrame());
   return m_initialViewportSize.height();
 }
 
 }  // namespace blink