Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Unified Diff: build/android/test_runner.py

Issue 2501693002: Make platform-mode default for JUnit tests. (Closed)
Patch Set: rebase!!!!! Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/junit/test_runner.py ('k') | build/android/test_runner.pydeps » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/test_runner.py
diff --git a/build/android/test_runner.py b/build/android/test_runner.py
index 051664bc72e82eef3f1e26079f85915e3a12c244..f872ad0d5cda6e86ec6b1680f18188888f790824 100755
--- a/build/android/test_runner.py
+++ b/build/android/test_runner.py
@@ -36,8 +36,6 @@ from pylib.base import test_instance_factory
from pylib.base import test_run_factory
from pylib.constants import host_paths
from pylib.linker import setup as linker_setup
-from pylib.junit import setup as junit_setup
-from pylib.junit import test_dispatcher as junit_dispatcher
from pylib.results import json_results
from pylib.results import report_results
@@ -579,22 +577,6 @@ def _RunLinkerTests(args, devices):
return exit_code
-def _RunJUnitTests(args):
- """Subcommand of RunTestsCommand which runs junit tests."""
- runner_factory, tests = junit_setup.Setup(args)
- results, exit_code = junit_dispatcher.RunTests(tests, runner_factory)
-
- report_results.LogFull(
- results=results,
- test_type='JUnit',
- test_package=args.test_suite)
-
- if args.json_results_file:
- json_results.GenerateJsonResultsFile([results], args.json_results_file)
-
- return exit_code
-
-
def _RunPythonTests(args):
"""Subcommand of RunTestsCommand which runs python unit tests."""
suite_vars = constants.PYTHON_UNIT_TEST_SUITES[args.suite_name]
@@ -644,7 +626,8 @@ def _GetAttachedDevices(blacklist_file, test_device, enable_cache, num_retries):
return sorted(attached_devices)
-_DEFAULT_PLATFORM_MODE_TESTS = ['gtest', 'instrumentation', 'monkey', 'perf']
+_DEFAULT_PLATFORM_MODE_TESTS = ['gtest', 'instrumentation', 'junit',
+ 'monkey', 'perf']
def RunTestsCommand(args): # pylint: disable=too-many-return-statements
@@ -682,8 +665,6 @@ def RunTestsCommand(args): # pylint: disable=too-many-return-statements
if command == 'linker':
return _RunLinkerTests(args, get_devices())
- elif command == 'junit':
- return _RunJUnitTests(args)
elif command == 'python':
return _RunPythonTests(args)
else:
« no previous file with comments | « build/android/pylib/junit/test_runner.py ('k') | build/android/test_runner.pydeps » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698