Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Side by Side Diff: sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart

Issue 25016002: Fix (bogus) warnings related to the use of Function in dart2js. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart_backend; 5 part of dart_backend;
6 6
7 // TODO(ahe): This class is simply wrong. This backend should use 7 // TODO(ahe): This class is simply wrong. This backend should use
8 // elements when it can, not AST nodes. Perhaps a [Map<Element, 8 // elements when it can, not AST nodes. Perhaps a [Map<Element,
9 // TreeElements>] is what is needed. 9 // TreeElements>] is what is needed.
10 class ElementAst { 10 class ElementAst {
(...skipping 601 matching lines...) Expand 10 before | Expand all | Expand 10 after
612 typeAnnotation.visitChildren(this); 612 typeAnnotation.visitChildren(this);
613 } 613 }
614 614
615 void collect() { 615 void collect() {
616 compiler.withCurrentElement(rootElement, () { 616 compiler.withCurrentElement(rootElement, () {
617 rootElement.parseNode(compiler).accept(this); 617 rootElement.parseNode(compiler).accept(this);
618 }); 618 });
619 } 619 }
620 } 620 }
621 621
622 compareBy(f) => (x, y) => f(x).compareTo(f(y)); 622 Comparator compareBy(f) => (x, y) => f(x).compareTo(f(y));
623 623
624 List sorted(Iterable l, comparison) { 624 List sorted(Iterable l, comparison) {
625 final result = new List.from(l); 625 final result = new List.from(l);
626 result.sort(comparison); 626 result.sort(comparison);
627 return result; 627 return result;
628 } 628 }
629 629
630 compareElements(e0, e1) { 630 compareElements(e0, e1) {
631 int result = compareBy((e) => e.getLibrary().canonicalUri.toString())(e0, e1); 631 int result = compareBy((e) => e.getLibrary().canonicalUri.toString())(e0, e1);
632 if (result != 0) return result; 632 if (result != 0) return result;
633 return compareBy((e) => e.position().charOffset)(e0, e1); 633 return compareBy((e) => e.position().charOffset)(e0, e1);
634 } 634 }
635 635
636 List<Element> sortElements(Iterable<Element> elements) => 636 List<Element> sortElements(Iterable<Element> elements) =>
637 sorted(elements, compareElements); 637 sorted(elements, compareElements);
OLDNEW
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698