Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2501563002: Remove Selector.sameNameHack (Closed)

Created:
4 years, 1 month ago by Johnni Winther
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -11 lines) Patch
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 1 chunk +3 lines, -3 lines 1 comment Download
M pkg/compiler/lib/src/universe/selector.dart View 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
https://codereview.chromium.org/2501563002/diff/1/pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart File pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart (left): https://codereview.chromium.org/2501563002/diff/1/pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart#oldcode1693 pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart:1693: !mask.canHit(target, selector, compiler.closedWorld))) { The target is statically known ...
4 years, 1 month ago (2016-11-14 12:01:29 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 1 month ago (2016-11-14 17:42:13 UTC) #3
Johnni Winther
4 years, 1 month ago (2016-11-15 12:03:36 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
128727744c0a19fe1e1918cd56f55488037123a8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698