Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 2501553003: Fix bug in HttpURLFetcher that dropped the response headers (Closed)

Created:
4 years, 1 month ago by alex clarke (OOO till 29th)
Modified:
4 years, 1 month ago
Reviewers:
Eric Seckler
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix bug in HttpURLFetcher that dropped the response headers BUG=664989 Committed: https://crrev.com/1cf8ef72e2667c0b7df484fd906f95e7275e00f4 Cr-Commit-Position: refs/heads/master@{#432033}

Patch Set 1 #

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M headless/public/util/http_url_fetcher.cc View 1 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
alex clarke (OOO till 29th)
4 years, 1 month ago (2016-11-14 15:45:08 UTC) #2
Eric Seckler
I think there might be some files missing? :)
4 years, 1 month ago (2016-11-14 15:56:41 UTC) #3
Eric Seckler
lgtm
4 years, 1 month ago (2016-11-14 16:11:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501553003/20001
4 years, 1 month ago (2016-11-14 16:12:52 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-15 00:51:22 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 01:04:40 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1cf8ef72e2667c0b7df484fd906f95e7275e00f4
Cr-Commit-Position: refs/heads/master@{#432033}

Powered by Google App Engine
This is Rietveld 408576698