Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2501553002:
[test] Add tests for definitions in object literal. (Closed)
|
Created:
4 years, 1 month ago by Franzi Modified:
4 years, 1 month ago Reviewers:
Benedikt Meurer CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[test] Add tests for definitions in object literal.
Properties can be defined inside the object literal (ES6) or after
object creation. The behavior differes if there are accessors, interceptors
or proxies in the Object prototype chain.
These test cases assure we preserve correct behavior as we
improve performance of definitions in literals.
BUG=v8:5624
Committed: https://crrev.com/0188c3fba32809f71693fc169ab64db12de0956d
Cr-Commit-Position: refs/heads/master@{#41024}
Patch Set 1 #Patch Set 2 : [test] Add test for object literal definition with interceptors. #
Total comments: 1
Patch Set 3 : Move flag into namespace. #Patch Set 4 : Do not intercept before Context::New() is done. #
Messages
Total messages: 46 (40 generated)
The CQ bit was checked by franzih@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
franzih@chromium.org changed reviewers: + bmeurer@chromium.org
Hi Benedikt, I added tests to make sure we treat definitions inside object literals correct for edge cases like proxies and interceptors. Please take a look. Thanks, Franzi
https://codereview.chromium.org/2501553002/diff/20001/test/cctest/test-api-in... File test/cctest/test-api-interceptors.cc (right): https://codereview.chromium.org/2501553002/diff/20001/test/cctest/test-api-in... test/cctest/test-api-interceptors.cc:659: bool getter_callback_was_called = false; Nit: Move this into the namespace.
LGTM once nits addressed.
The CQ bit was checked by franzih@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...) v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
The CQ bit was checked by franzih@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #4 (id:60001) has been deleted
The CQ bit was checked by franzih@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by franzih@chromium.org
The CQ bit was checked by franzih@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by franzih@chromium.org
The CQ bit was checked by franzih@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by franzih@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by franzih@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...) v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
Patchset #8 (id:160001) has been deleted
Patchset #7 (id:140001) has been deleted
Patchset #6 (id:120001) has been deleted
Patchset #5 (id:100001) has been deleted
The CQ bit was checked by franzih@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by franzih@chromium.org
Patchset #5 (id:180001) has been deleted
Patchset #4 (id:80001) has been deleted
The CQ bit was checked by franzih@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by franzih@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org Link to the patchset: https://codereview.chromium.org/2501553002/#ps200001 (title: "Do not intercept before Context::New() is done.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #4 (id:200001)
Message was sent while issue was closed.
Description was changed from ========== [test] Add tests for definitions in object literal. Properties can be defined inside the object literal (ES6) or after object creation. The behavior differes if there are accessors, interceptors or proxies in the Object prototype chain. These test cases assure we preserve correct behavior as we improve performance of definitions in literals. BUG=v8:5624 ========== to ========== [test] Add tests for definitions in object literal. Properties can be defined inside the object literal (ES6) or after object creation. The behavior differes if there are accessors, interceptors or proxies in the Object prototype chain. These test cases assure we preserve correct behavior as we improve performance of definitions in literals. BUG=v8:5624 Committed: https://crrev.com/0188c3fba32809f71693fc169ab64db12de0956d Cr-Commit-Position: refs/heads/master@{#41024} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/0188c3fba32809f71693fc169ab64db12de0956d Cr-Commit-Position: refs/heads/master@{#41024} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
