Loading: move FontResource to core/loader/resource

Loading: move FontResource to core/loader/resource

To remove core/ dependency so that core/fetch can be moved under
platform, move FontResource and FontResourceClient classes
to core/loader/resource/.

BUG=655920
Committed: https://crrev.com/36e4ca5c1a4975972816b84d110c35f70c956798
Cr-Commit-Position: refs/heads/master@{#435140}

[Takashi Toyoshima, 2016-11-15 02:04:36]

Description was changed from

==========
Loading: move FontResource to core/loader/resource

BUG=655920
==========

to

==========
Loading: move FontResource to core/loader/resource

BUG=655920
==========

[Takashi Toyoshima, 2016-11-15 02:04:36]

toyoshim@chromium.org changed reviewers:
+ hiroshige@chromium.org, yhirano@chromium.org

[yhirano, 2016-11-15 03:21:40]

On 2016/11/15 02:05:22, toyoshim wrote:

rebase needed? I think MockFetchContext.h is added as
https://codereview.chromium.org/2495003002/.

[hiroshige, 2016-11-15 10:08:34]

Splitting this CL into
1. Test refactoring and
2. Bulk mechanical directory move
might be conceptually cleaner.

https://codereview.chromium.org/2501543002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/resource/FontResourceTest.cpp
(right):

https://codereview.chromium.org/2501543002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/resource/FontResourceTest.cpp:15: #include
"platform/scheduler/test/fake_web_task_runner.h"
Is this include needed?

https://codereview.chromium.org/2501543002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/resource/FontResourceTest.cpp:16: #include
"platform/testing/weburl_loader_mock.h"
ditto.

[Takashi Toyoshima, 2016-11-16 08:08:49]

ok, I made a separate CL that just makes changes on tests.
https://codereview.chromium.org/2510603002/

[Takashi Toyoshima, 2016-11-16 10:21:10]

Description was changed from

==========
Loading: move FontResource to core/loader/resource

BUG=655920
==========

to

==========
Loading: move FontResource to core/loader/resource

(test changes are split into another CL, and this CL is suspended until the test
part is finished)

BUG=655920
==========

[hiroshige, 2016-11-17 06:34:15]

lgtm with:
- rebase is needed after https://codereview.chromium.org/2510603002/ (Commment
#6) and https://codereview.chromium.org/2495003002/ (Comment #4)
- nits in Comment #5.

[Takashi Toyoshima, 2016-11-17 06:59:14]

After a rebase, I noticed ToT introduced additional dependency from
MockResourceClients.h to FontResource.h.
I'd split MockResourceClients.h for this move.

[Takashi Toyoshima, 2016-11-29 08:15:10]

Description was changed from

==========
Loading: move FontResource to core/loader/resource

(test changes are split into another CL, and this CL is suspended until the test
part is finished)

BUG=655920
==========

to

==========
Loading: move FontResource to core/loader/resource

To remove core/ dependency so that core/fetch can be moved under
platform, move FontResource and FontResourceClient classes
to core/loader/resource/.

BUG=655920
==========

[Takashi Toyoshima, 2016-11-29 08:27:06]

https://codereview.chromium.org/2501543002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/resource/FontResourceTest.cpp
(right):

https://codereview.chromium.org/2501543002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/resource/FontResourceTest.cpp:15: #include
"platform/scheduler/test/fake_web_task_runner.h"
On 2016/11/15 10:08:34, hiroshige wrote:
> Is this include needed?

Done.

https://codereview.chromium.org/2501543002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/resource/FontResourceTest.cpp:16: #include
"platform/testing/weburl_loader_mock.h"
On 2016/11/15 10:08:34, hiroshige wrote:
> ditto.

Done.

[Takashi Toyoshima, 2016-11-29 08:27:29]

yhirano: ptal, this patch does not have any dependency now.

[Takashi Toyoshima, 2016-11-29 08:27:37]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 08:27:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2016-11-29 08:32:44]

lgtm

[commit-bot: I haz the power, 2016-11-29 08:46:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 08:46:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Takashi Toyoshima, 2016-11-29 09:47:31]

toyoshim@chromium.org changed reviewers:
+ kouhei@chromium.org

[Takashi Toyoshima, 2016-11-29 09:48:26]

+kouhei for core/css, core/frame, core/inspector

[Takashi Toyoshima, 2016-11-29 09:48:38]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 09:49:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kouhei (in TOK), 2016-11-29 10:09:38]

lgtm

[commit-bot: I haz the power, 2016-11-29 11:23:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 11:23:36]

Dry run: This issue passed the CQ dry run.

[kouhei (in TOK), 2016-11-30 01:41:58]

The CQ bit was checked by kouhei@chromium.org

[kouhei (in TOK), 2016-11-30 01:41:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
hiroshige@chromium.org, yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2501543002/#ps40001
(title: "one rebase error for webkit_unit_tests build")

[commit-bot: I haz the power, 2016-11-30 01:43:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 03:45:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 03:45:04]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[Takashi Toyoshima, 2016-11-30 05:12:47]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2016-11-30 05:13:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 07:50:14]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480482767104010,
"parent_rev": "38b5461c22296d2f75cecb71d9d40c79202eaeaf", "commit_rev":
"7bfc1a9539ab17aea7fa9b3e3fd114e8fb9d1c0d"}

[commit-bot: I haz the power, 2016-11-30 07:50:59]

Description was changed from

==========
Loading: move FontResource to core/loader/resource

To remove core/ dependency so that core/fetch can be moved under
platform, move FontResource and FontResourceClient classes
to core/loader/resource/.

BUG=655920
==========

to

==========
Loading: move FontResource to core/loader/resource

To remove core/ dependency so that core/fetch can be moved under
platform, move FontResource and FontResourceClient classes
to core/loader/resource/.

BUG=655920
==========

[commit-bot: I haz the power, 2016-11-30 07:51:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-30 07:53:50]

Description was changed from

==========
Loading: move FontResource to core/loader/resource

To remove core/ dependency so that core/fetch can be moved under
platform, move FontResource and FontResourceClient classes
to core/loader/resource/.

BUG=655920
==========

to

==========
Loading: move FontResource to core/loader/resource

To remove core/ dependency so that core/fetch can be moved under
platform, move FontResource and FontResourceClient classes
to core/loader/resource/.

BUG=655920

Committed: https://crrev.com/36e4ca5c1a4975972816b84d110c35f70c956798
Cr-Commit-Position: refs/heads/master@{#435140}
==========

[commit-bot: I haz the power, 2016-11-30 07:53:51]

Patchset 3 (id:??) landed as
https://crrev.com/36e4ca5c1a4975972816b84d110c35f70c956798
Cr-Commit-Position: refs/heads/master@{#435140}