Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 250153003: Fix gs url in logcat dump, and set content type to text/plain (Closed)

Created:
6 years, 8 months ago by luqui
Modified:
6 years, 8 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix gs url in logcat dump, and set content type to text/plain BUG=362787 TBR=navabi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265839

Patch Set 1 #

Patch Set 2 : Remove space as advised by gsutil docs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M build/android/buildbot/bb_device_steps.py View 1 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
luqui
ptal
6 years, 8 months ago (2014-04-23 21:03:30 UTC) #1
navabi
6 years, 8 months ago (2014-04-24 00:16:02 UTC) #2
luqui
The CQ bit was checked by luqui@chromium.org
6 years, 8 months ago (2014-04-24 00:17:58 UTC) #3
navabi
lgtm Just curious as to what is the difference for things we upload to GS_URL ...
6 years, 8 months ago (2014-04-24 00:18:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/luqui@chromium.org/250153003/20001
6 years, 8 months ago (2014-04-24 00:19:16 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 01:08:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-24 01:08:14 UTC) #7
luqui
navabi, you used the wrong account. TBRing.
6 years, 8 months ago (2014-04-24 01:13:06 UTC) #8
luqui
The CQ bit was checked by luqui@chromium.org
6 years, 8 months ago (2014-04-24 01:13:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/luqui@chromium.org/250153003/20001
6 years, 8 months ago (2014-04-24 01:13:45 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 03:39:56 UTC) #11
Message was sent while issue was closed. 
Change committed as 265839

Powered by Google App Engine
This is Rietveld 408576698