Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2501523003: Add UseCounter on Event::stop{Immediate,}Propagation(). (Closed)

Created:
4 years, 1 month ago by mlamouri (slow - plz ping)
Modified:
4 years, 1 month ago
Reviewers:
esprehn, Ilya Sherman
CC:
asvitkine+watch_chromium.org, blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UseCounter on Event::stop{Immediate,}Propagation(). BUG=None Committed: https://crrev.com/7c520526ebc537587d82b4449c8c32128a188f7c Cr-Commit-Position: refs/heads/master@{#432104}

Patch Set 1 #

Total comments: 2

Patch Set 2 : measure stop propagation too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M third_party/WebKit/Source/core/events/Event.idl View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
mlamouri (slow - plz ping)
4 years, 1 month ago (2016-11-14 23:56:45 UTC) #2
esprehn
https://codereview.chromium.org/2501523003/diff/1/third_party/WebKit/Source/core/events/Event.idl File third_party/WebKit/Source/core/events/Event.idl (right): https://codereview.chromium.org/2501523003/diff/1/third_party/WebKit/Source/core/events/Event.idl#newcode38 third_party/WebKit/Source/core/events/Event.idl:38: void stopPropagation(); Do we want to use counter stopPropagation ...
4 years, 1 month ago (2016-11-15 00:01:19 UTC) #5
esprehn
lgtm
4 years, 1 month ago (2016-11-15 00:01:45 UTC) #6
mlamouri (slow - plz ping)
+isherman@ for histograms.xml https://codereview.chromium.org/2501523003/diff/1/third_party/WebKit/Source/core/events/Event.idl File third_party/WebKit/Source/core/events/Event.idl (right): https://codereview.chromium.org/2501523003/diff/1/third_party/WebKit/Source/core/events/Event.idl#newcode38 third_party/WebKit/Source/core/events/Event.idl:38: void stopPropagation(); On 2016/11/15 at 00:01:19, ...
4 years, 1 month ago (2016-11-15 00:05:23 UTC) #9
Ilya Sherman
histograms.xml lgtm
4 years, 1 month ago (2016-11-15 01:55:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501523003/20001
4 years, 1 month ago (2016-11-15 03:03:12 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 04:57:30 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7c520526ebc537587d82b4449c8c32128a188f7c
Cr-Commit-Position: refs/heads/master@{#432104}

Powered by Google App Engine
This is Rietveld 408576698