Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 2501503005: [Interpreter] Add SetPendingMessage bytecode. (Closed)

Created:
4 years, 1 month ago by rmcilroy
Modified:
4 years, 1 month ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add SetPendingMessage bytecode. Adds a bytecode to set and retrieve the pending message. This avoids a runtime call in finally blocks, and also ensures that TurboFan builds a graph using the SetMessage / LoadMessage nodes instead of inserting a runtime call. BUG=chromium:662334 Committed: https://crrev.com/fe9ac966ccde51fa981af203353f0c17c9f49897 Cr-Commit-Position: refs/heads/master@{#41023}

Patch Set 1 #

Patch Set 2 : cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -110 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/runtime/runtime-interpreter.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForOf.golden View 20 chunks +52 lines, -40 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 11 chunks +29 lines, -20 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/TryCatch.golden View 3 chunks +12 lines, -9 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/TryFinally.golden View 10 chunks +27 lines, -18 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
rmcilroy
Michi PTAL, thanks.
4 years, 1 month ago (2016-11-15 21:12:40 UTC) #4
Michael Starzinger
LGTM.
4 years, 1 month ago (2016-11-16 09:01:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501503005/20001
4 years, 1 month ago (2016-11-16 10:19:40 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-16 10:46:31 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:35:43 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fe9ac966ccde51fa981af203353f0c17c9f49897
Cr-Commit-Position: refs/heads/master@{#41023}

Powered by Google App Engine
This is Rietveld 408576698