Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 25015003: gfx: Create a separate gfx component out of ui. (Closed)

Created:
7 years, 2 months ago by sadrul
Modified:
7 years, 2 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, hclam+watch_chromium.org, sergeyu+watch_chromium.org, tfarina, amit, sanjeevr, jam, garykac+watch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, wez+watch_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, weitaosu+watch_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org
Visibility:
Public.

Description

gfx: Create a separate gfx component out of ui. Landed previously in r225857, which was reverted in r225859 because it broke android tests. BUG=103304 R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225909

Patch Set 1 : . #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Patch Set 10 : . #

Patch Set 11 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+528 lines, -326 lines) Patch
M android_webview/native/webview_native.gyp View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M ash/ash.gyp View 1 2 3 4 5 3 chunks +3 lines, -0 lines 0 comments Download
M cc/cc.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M cc/cc_tests.gyp View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/chrome.gyp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser_ui_views.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 7 8 9 10 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/test/base/chrome_test_suite.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +2 lines, -0 lines 0 comments Download
M components/autofill.gypi View 1 2 3 4 5 3 chunks +3 lines, -0 lines 0 comments Download
M components/json_schema.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M components/user_prefs.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M components/web_contents_delegate_android.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/app/android/library_loader_hooks.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +4 lines, -0 lines 0 comments Download
M content/content_app.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_child.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/content_common.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/content_ppapi_plugin.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/content_shell.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/content_tests.gypi View 7 chunks +9 lines, -2 lines 0 comments Download
M content/public/test/content_test_suite_base.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +2 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth.gyp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer_service.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gpu/gles2_conform_support/gles2_conform_support.gyp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M gpu/gpu.gyp View 3 chunks +3 lines, -3 lines 0 comments Download
M media/media.gyp View 3 chunks +3 lines, -0 lines 0 comments Download
M printing/printing.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M remoting/remoting.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/memory_watcher/memory_watcher.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/set_default_handler/set_default_handler.gyp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/gfx/BitmapHelper.java View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/android/ui_jni_registrar.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -2 lines 0 comments Download
M ui/app_list/app_list.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/aura.gyp View 1 2 3 4 5 5 chunks +5 lines, -0 lines 0 comments Download
M ui/compositor/compositor.gyp View 1 2 3 4 5 3 chunks +3 lines, -0 lines 0 comments Download
A + ui/gfx/android/gfx_jni_registrar.h View 1 2 3 4 5 6 7 8 9 1 chunk +7 lines, -9 lines 0 comments Download
A ui/gfx/android/gfx_jni_registrar.cc View 1 2 3 4 5 6 7 8 1 chunk +26 lines, -0 lines 0 comments Download
M ui/gfx/android/java_bitmap.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A ui/gfx/gfx.gyp View 1 2 3 4 5 6 7 8 1 chunk +385 lines, -0 lines 0 comments Download
M ui/gfx/gfx_export.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/gfx/rect_base_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/keyboard/keyboard.gyp View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M ui/message_center/message_center.gyp View 1 2 3 4 5 6 3 chunks +3 lines, -0 lines 0 comments Download
M ui/native_theme/native_theme.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/oak/oak.gyp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M ui/snapshot/snapshot.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/surface/surface.gyp View 1 2 3 4 5 6 2 chunks +2 lines, -0 lines 0 comments Download
M ui/test/test_suite.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +2 lines, -0 lines 0 comments Download
M ui/ui.gyp View 11 chunks +2 lines, -301 lines 0 comments Download
M ui/ui_unittests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M ui/v2/v2.gyp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/webview/webview.gyp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/views.gyp View 1 2 3 4 5 6 7 chunks +7 lines, -0 lines 0 comments Download
M webkit/common/gpu/webkit_gpu.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/common/webkit_common.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 2 3 4 5 6 2 chunks +2 lines, -0 lines 0 comments Download
M webkit/renderer/compositor_bindings/compositor_bindings.gyp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M webkit/renderer/webkit_renderer.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M win8/delegate_execute/delegate_execute.gyp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sadrul
I probably need a few more iterations through the trybots, but this is looking somewhat ...
7 years, 2 months ago (2013-09-27 23:25:54 UTC) #1
Ben Goodger (Google)
lgtm
7 years, 2 months ago (2013-09-28 00:42:15 UTC) #2
tfarina
I have update the CL description to reference crbug.com/103304
7 years, 2 months ago (2013-09-28 00:55:43 UTC) #3
tfarina
https://codereview.chromium.org/25015003/diff/11002/ui/gfx/gfx.gyp File ui/gfx/gfx.gyp (right): https://codereview.chromium.org/25015003/diff/11002/ui/gfx/gfx.gyp#newcode9 ui/gfx/gfx.gyp:9: 'includes': [ do you need this empty list?
7 years, 2 months ago (2013-09-28 00:56:29 UTC) #4
sadrul
Committed patchset #10 manually as r225857 (presubmit successful).
7 years, 2 months ago (2013-09-28 17:08:09 UTC) #5
ckocagil
Reverted due to Android failures. From a quick glance it looks like something's wrong with ...
7 years, 2 months ago (2013-09-28 19:14:33 UTC) #6
sadrul
7 years, 2 months ago (2013-09-30 02:47:54 UTC) #7
Message was sent while issue was closed. 
Committed patchset #11 manually as r225909 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698