Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2501493002: Revert "MainFrame scrollbars should work with RFV instead of FV" (Closed)

Created:
4 years, 1 month ago by charliea (OOO until 10-5)
Modified:
4 years, 1 month ago
Reviewers:
bokan, skobes, ymalik, jbroman, sky
CC:
chromium-reviews, dshwang, rouslan+autofill_chromium.org, blink-reviews-paint_chromium.org, sebsg+autofillwatch_chromium.org, blink-reviews, jdonnelly+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, mac-reviews_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "MainFrame scrollbars should work with RFV instead of FV" This reverts commit 322db3d6f1f9eb4b9cd6a0054999718c24b1f076. This CL was shown to cause a significant increase in the power required to scroll down a page on the Macbook Pro Retinas, from about 12W before this patch to 20W after. It appears that this aligned with a similar regression in CPU usage. TBR=ymalik,bokan,skobes,jbroman,sky BUG=456861, 664809 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/7babb3129df2085a55a7fd66d7f069622a16b795 Cr-Commit-Position: refs/heads/master@{#431814}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -416 lines) Patch
M chrome/renderer/autofill/page_click_tracker_browsertest.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/scale-and-scroll-iframe-window.html View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/transforms/selection-bounds-in-transformed-view.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-centered-inline-under-fixed-pos-expected.txt View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/window-resize-vertical-writing-mode-expected.txt View 2 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/window-resize-vertical-writing-mode-expected.txt View 2 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/window-resize-vertical-writing-mode-expected.txt View 2 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.h View 4 chunks +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 9 chunks +53 lines, -65 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RootFrameViewport.h View 2 chunks +5 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RootFrameViewport.cpp View 2 chunks +0 lines, -85 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ScrollbarManager.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ScrollbarManager.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableArea.h View 7 chunks +12 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/VisualViewportTest.cpp View 55 chunks +63 lines, -122 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
charliea (OOO until 10-5)
4 years, 1 month ago (2016-11-13 21:41:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501493002/1
4 years, 1 month ago (2016-11-13 21:41:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-13 23:34:38 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-13 23:43:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7babb3129df2085a55a7fd66d7f069622a16b795
Cr-Commit-Position: refs/heads/master@{#431814}

Powered by Google App Engine
This is Rietveld 408576698