Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: chrome/renderer/resources/extensions/media_galleries_custom_bindings.js

Issue 250143002: Media Galleries API: Audio/Video attached pictures support. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Create Blobs on browser-process, eliminating two IPC copies. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/media_galleries_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/media_galleries_custom_bindings.js b/chrome/renderer/resources/extensions/media_galleries_custom_bindings.js
index 9b51fcc271685b3f9afbc0011f1aa4decbeb0cdd..0c61b8be93cfc552446ffd153ab3b3adf1451fe5 100644
--- a/chrome/renderer/resources/extensions/media_galleries_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/media_galleries_custom_bindings.js
@@ -103,6 +103,22 @@ binding.registerCustomHook(function(bindingsAPI, extensionId) {
var blobUuid = blobNatives.GetBlobUuid(mediaFile)
return [blobUuid, options, callback];
});
+
+ apiFunctions.setCustomCallback('getMetadata',
+ function(name, request, response) {
+ if (response.attachedImages) {
+ for (var i = 0; i < response.attachedImages.length; i++) {
+ var image = response.attachedImages[i];
+ var blob = blobNatives.TakeBrowserProcessBlob(
+ image.blobUUID, image.type, image.size);
michaeln 2014/05/01 21:27:35 nit: indent by 2 more
tommycli 2014/05/07 21:39:04 Done.
+ response.metadata.attachedImages.push(blob);
+ }
+ }
+
+ if (request.callback)
+ request.callback(response.metadata);
+ request.callback = null;
+ });
});
exports.binding = binding.generate();

Powered by Google App Engine
This is Rietveld 408576698