Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Unified Diff: chrome/browser/extensions/api/media_galleries/media_galleries_api.h

Issue 250143002: Media Galleries API: Audio/Video attached pictures support. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Create Blobs on browser-process, eliminating two IPC copies. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/media_galleries/media_galleries_api.h
diff --git a/chrome/browser/extensions/api/media_galleries/media_galleries_api.h b/chrome/browser/extensions/api/media_galleries/media_galleries_api.h
index 4a85487c169932904a11e2554d5bf065a90d7e31..eef4056e15f319d6da4452bab4bec1dfdc704ef2 100644
--- a/chrome/browser/extensions/api/media_galleries/media_galleries_api.h
+++ b/chrome/browser/extensions/api/media_galleries/media_galleries_api.h
@@ -18,6 +18,7 @@
#include "chrome/browser/media_galleries/media_file_system_registry.h"
#include "chrome/browser/media_galleries/media_scan_manager_observer.h"
#include "chrome/common/extensions/api/media_galleries.h"
+#include "chrome/common/media_galleries/metadata_types.h"
#include "components/storage_monitor/media_storage_util.h"
#include "extensions/browser/browser_context_keyed_api_factory.h"
@@ -263,15 +264,25 @@ class MediaGalleriesGetMetadataFunction : public ChromeAsyncExtensionFunction {
private:
// Bottom half for RunImpl, invoked after the preferences is initialized.
- void OnPreferencesInit(bool mime_type_only, const std::string& blob_uuid);
+ void OnPreferencesInit(bool mime_type_only, bool get_attached_images,
+ const std::string& blob_uuid);
- void SniffMimeType(bool mime_type_only,
- const std::string& blob_uuid,
- scoped_ptr<std::string> blob_header,
- int64 total_blob_length);
+ void GetMetadata(bool mime_type_only, bool get_attached_images,
+ const std::string& blob_uuid,
+ scoped_ptr<std::string> blob_header,
+ int64 total_blob_length);
void OnSafeMediaMetadataParserDone(
- bool parse_success, base::DictionaryValue* metadata_dictionary);
+ bool parse_success, base::DictionaryValue* metadata_dictionary,
+ const std::vector<metadata::AttachedImage>& attached_images);
+
+ std::vector<std::string> CreateBlobsOnIOThread(
+ const std::vector<metadata::AttachedImage>& attached_images);
+
+ void FinishWithBlobsOnUIThread(
+ base::DictionaryValue* metadata_dictionary,
+ const std::vector<metadata::AttachedImage>& attached_images,
+ const std::vector<std::string>& blob_uuids);
};
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698