Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: content/browser/frame_host/navigation_handle_impl.h

Issue 2501343003: PlzNavigate: AppCache support. (Closed)
Patch Set: Address review comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_handle_impl.h
diff --git a/content/browser/frame_host/navigation_handle_impl.h b/content/browser/frame_host/navigation_handle_impl.h
index c02844b80f469e4fffd04f4dabee9f9eb87d0584..8cf136dd832681bb5728ef3e88fbe080d0fbd5fd 100644
--- a/content/browser/frame_host/navigation_handle_impl.h
+++ b/content/browser/frame_host/navigation_handle_impl.h
@@ -32,6 +32,8 @@ struct FrameHostMsg_DidCommitProvisionalLoad_Params;
namespace content {
+class AppCacheNavigationHandle;
+class ChromeAppCacheService;
class NavigationUIData;
class NavigatorDelegate;
class ResourceRequestBodyImpl;
@@ -198,6 +200,12 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
return service_worker_handle_.get();
}
+ // PlzNavigate
+ void InitAppCacheHandle(ChromeAppCacheService* appcache_service);
+ AppCacheNavigationHandle* appcache_handle() const {
+ return appcache_handle_.get();
+ }
+
typedef base::Callback<void(NavigationThrottle::ThrottleCheckResult)>
ThrottleChecksFinishedCallback;
@@ -430,6 +438,12 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
GURL searchable_form_url_;
std::string searchable_form_encoding_;
+ // PlzNavigate
+ // Manages the lifetime of a pre-created AppCacheHost until a browser side
+ // navigation is committed, i.e we have a renderer process ready to service
clamy 2016/11/30 17:40:22 nit: s/is committed/is ready to be committed
ananta 2016/12/01 05:14:59 Done.
+ // the navigation request.
+ std::unique_ptr<AppCacheNavigationHandle> appcache_handle_;
+
base::WeakPtrFactory<NavigationHandleImpl> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(NavigationHandleImpl);

Powered by Google App Engine
This is Rietveld 408576698