PlzNavigate: AppCache support.

content/renderer/render_frame_impl.cc

Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 593d5755c04a9acec50d2382b64e560eafe1ec75..ec6d667b37cf628a51653ab33f68799e2e21c81c 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -66,6 +66,7 @@
 #include "content/common/site_isolation_policy.h"
 #include "content/common/swapped_out_messages.h"
 #include "content/common/view_messages.h"
+#include "content/public/common/appcache_info.h"
 #include "content/public/common/associated_interface_provider.h"
 #include "content/public/common/bindings_policy.h"
 #include "content/public/common/browser_side_navigation_policy.h"
@@ -1107,6 +1108,7 @@ RenderFrameImpl::RenderFrameImpl(const CreateParams& params)
       frame_binding_(this),
       host_zoom_binding_(this),
       has_accessed_initial_document_(false),
+      appcache_host_id_(kAppCacheNoHostId),
       weak_factory_(this) {
   // We don't have a service_manager::Connection at this point, so use empty
   // identity/specs.
@@ -2853,7 +2855,8 @@ blink::WebApplicationCacheHost* RenderFrameImpl::createApplicationCacheHost(
     return NULL;
   return new RendererWebApplicationCacheHostImpl(
       RenderViewImpl::FromWebView(frame_->view()), client,
-      RenderThreadImpl::current()->appcache_dispatcher()->backend_proxy());
+      RenderThreadImpl::current()->appcache_dispatcher()->backend_proxy(),
+      appcache_host_id_);
 }
 
 blink::WebWorkerContentSettingsClientProxy*
@@ -4999,8 +5002,13 @@ void RenderFrameImpl::OnCommitNavigation(
       request_params.has_user_gesture ? new blink::WebScopedUserGesture(frame_)
                                       : nullptr);
 
+  appcache_host_id_ = request_params.appcache_host_id;

[clamy, 2016/11/25 13:32:24]

We store the request params in NavigateInternal, so we should manage to get the
id directly from them and avoid adding an extra parameter to RenderFrameImpl.

[ananta, 2016/11/28 21:36:53]

We save the request params in the pending_navigation_params_ member. However
that gets reset before the RenderFrameImpl::createApplicationCacheHost()
function is called. Leaving this as is.

[clamy, 2016/11/30 17:40:22]

You can still access them through the DataSource DocumentState's NavigationState
(in its NavigationStateImpl version). I would prefer we use them rather than
adding a member variable.

[ananta, 2016/12/01 05:14:59]

It looks like the right value is available via the provisionalDataSource()
function in the frame. I changed the code to look for the
RequestNavigationParams() first in the provisional data source and if that is
not available then in the regular data source. This works correctly. Please 
check and see if this is ok.

[clamy, 2016/12/01 10:02:47]

Absolutely, this is what I meant. Sorry my comment wasn't clear: I forgot to
mention that I was talking about the provisional DataSource and not the current
one.

+
   NavigateInternal(common_params, StartNavigationParams(), request_params,
                    std::move(stream_override));
+
+  appcache_host_id_ = kAppCacheNoHostId;
+
   browser_side_navigation_pending_ = false;
 }