Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: content/browser/frame_host/navigation_handle_impl.cc

Issue 2501343003: PlzNavigate: AppCache support. (Closed)
Patch Set: Maintain a refcounted instance of ChromeAppCacheService in the AppCacheNavigationHandleCore instanc… Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_handle_impl.cc
diff --git a/content/browser/frame_host/navigation_handle_impl.cc b/content/browser/frame_host/navigation_handle_impl.cc
index ae9e5dbe57a7670f7f2835d180ace81f6c679869..4baf2b6bb544f91e37b72e09183fb55fe444f390 100644
--- a/content/browser/frame_host/navigation_handle_impl.cc
+++ b/content/browser/frame_host/navigation_handle_impl.cc
@@ -6,6 +6,8 @@
#include "base/debug/dump_without_crashing.h"
#include "base/logging.h"
+#include "content/browser/appcache/appcache_navigation_handle.h"
+#include "content/browser/appcache/appcache_service_impl.h"
#include "content/browser/browsing_data/clear_site_data_throttle.h"
#include "content/browser/child_process_security_policy_impl.h"
#include "content/browser/devtools/render_frame_devtools_agent_host.h"
@@ -413,6 +415,12 @@ void NavigationHandleImpl::InitServiceWorkerHandle(
new ServiceWorkerNavigationHandle(service_worker_context));
}
+void NavigationHandleImpl::InitAppCacheHandle(
+ ChromeAppCacheService* appcache_service) {
+ DCHECK(IsBrowserSideNavigationEnabled());
+ appcache_handle_.reset(new AppCacheNavigationHandle(appcache_service));
+}
+
void NavigationHandleImpl::WillStartRequest(
const std::string& method,
scoped_refptr<content::ResourceRequestBodyImpl> resource_request_body,
@@ -531,6 +539,11 @@ void NavigationHandleImpl::ReadyToCommitNavigation(
render_frame_host_ = render_frame_host;
state_ = READY_TO_COMMIT;
+ if (appcache_handle_.get()) {
clamy 2016/11/25 13:32:24 Note: at this point we have not committed the navi
ananta 2016/11/28 21:36:53 Yes. If the RFH is not going to change from this p
+ appcache_handle_->CommitNavigation(
+ render_frame_host->GetProcess()->GetID());
+ }
+
if (!IsRendererDebugURL(url_))
GetDelegate()->ReadyToCommitNavigation(this);
}

Powered by Google App Engine
This is Rietveld 408576698