content/browser/loader/navigation_url_loader_unittest.cc - Issue 2501343003: PlzNavigate: AppCache support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/navigation_url_loader_unittest.cc

Issue 2501343003: PlzNavigate: AppCache support. (Closed)

Patch Set: Add DCHECKs for PlzNavigate and fix a double Release problem which caused one unit_test to fail wit… Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/loader/navigation_url_loader_unittest.cc

diff --git a/content/browser/loader/navigation_url_loader_unittest.cc b/content/browser/loader/navigation_url_loader_unittest.cc

index a0b61b98c6be22254f18404b191e23faa69e88fb..d09a311dec33abf8b5bdafabc5cfdc9a4e60dd35 100644

--- a/content/browser/loader/navigation_url_loader_unittest.cc

+++ b/content/browser/loader/navigation_url_loader_unittest.cc

@@ -113,7 +113,7 @@ class NavigationURLLoaderTest : public testing::Test {

std::unique_ptr<NavigationRequestInfo> request_info(

new NavigationRequestInfo(common_params, begin_params, url,

url::Origin(url), true, false, false, -1,

- false, false));

+ false, false, 0, nullptr));

return NavigationURLLoader::Create(browser_context_.get(),

std::move(request_info), nullptr,