PlzNavigate: AppCache support.

content/browser/loader/resource_dispatcher_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // See http://dev.chromium.org/developers/design-documents/multi-process-resource-loading
 
 #include "content/browser/loader/resource_dispatcher_host_impl.h"
 
 #include <stddef.h>
 
@@ skipping 1553 matching lines @@
       new_request.get(), filter_->service_worker_context(), blob_context,
       child_id, request_data.service_worker_provider_id,
       should_skip_service_worker, request_data.fetch_request_mode,
       request_data.fetch_credentials_mode, request_data.fetch_redirect_mode,
       request_data.resource_type, request_data.fetch_request_context_type,
       request_data.fetch_frame_type, request_data.request_body,
       request_data.initiated_in_secure_context);
 
   // Have the appcache associate its extra info with the request.
   AppCacheInterceptor::SetExtraRequestInfo(
-      new_request.get(), filter_->appcache_service(), child_id,
+      new_request.get(), filter_->appcache_service(), child_id, -1,
       request_data.appcache_host_id, request_data.resource_type,
       request_data.should_reset_appcache);
 
   std::unique_ptr<ResourceHandler> handler(CreateResourceHandler(
       new_request.get(), request_data, sync_result_handler, route_id,
       process_type, child_id, resource_context, std::move(mojo_request),
       std::move(url_loader_client)));
 
   if (handler)
     BeginRequestInternal(std::move(new_request), std::move(handler));
@@ skipping 672 matching lines @@
 
   RequestContextFrameType frame_type =
       info.is_main_frame ? REQUEST_CONTEXT_FRAME_TYPE_TOP_LEVEL
                          : REQUEST_CONTEXT_FRAME_TYPE_NESTED;
   ServiceWorkerRequestHandler::InitializeForNavigation(
       new_request.get(), service_worker_handle_core, blob_context,
       info.begin_params.skip_service_worker, resource_type,
       info.begin_params.request_context_type, frame_type,
       info.are_ancestors_secure, info.common_params.post_data);
 
-  // TODO(davidben): Attach AppCacheInterceptor.
+  // Have the appcache associate its extra info with the request.
+  AppCacheInterceptor::SetExtraRequestInfo(

[michaeln, 2016/11/22 00:17:27]

Can the techique we used for service worker work here too?

Take a look at what InitializeForNavigation does and what the object hierarchy
is, notice it takes as input the ServiceWorkerNavigationHandleCore with is given
ownership of the pre-created host object. 

[ananta, 2016/11/23 04:05:14]

Added a new function AppCacheInterceptor::SetExtraRequestInfoForHost(). PTAL

+      new_request.get(), info.appcache_service, -1, info.frame_tree_node_id,
+      info.appcache_host_id, resource_type, false);
 
   std::unique_ptr<ResourceHandler> handler(
       new NavigationResourceHandler(new_request.get(), loader, delegate()));
 
-  // TODO(davidben): Pass in the appropriate appcache_service. Also fix the
-  // dependency on child_id/route_id. Those are used by the ResourceScheduler;
-  // currently it's a no-op.
-  handler =
-      AddStandardHandlers(new_request.get(), resource_type, resource_context,
-                          info.begin_params.request_context_type,
-                          nullptr,  // appcache_service
-                          -1,       // child_id
-                          -1,       // route_id
-                          std::move(handler));
+  // TODO(davidben): Fix the dependency on child_id/route_id. Those are used
+  // by the ResourceScheduler. currently it's a no-op.
+  handler = AddStandardHandlers(
+      new_request.get(), resource_type, resource_context,
+      info.begin_params.request_context_type, info.appcache_service,
+      -1,  // child_id
+      -1,  // route_id
+      std::move(handler));
 
   BeginRequestInternal(std::move(new_request), std::move(handler));
 }
 
 void ResourceDispatcherHostImpl::EnableStaleWhileRevalidateForTesting() {
   if (!async_revalidation_manager_)
     async_revalidation_manager_.reset(new AsyncRevalidationManager);
 }
 
 void ResourceDispatcherHostImpl::SetLoaderDelegate(
@@ skipping 499 matching lines @@
                                  &throttles);
     if (!throttles.empty()) {
       handler.reset(new ThrottlingResourceHandler(std::move(handler), request,
                                                   std::move(throttles)));
     }
   }
   return handler;
 }
 
 }  // namespace content