Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 2501333003: Event failed to dispatch after stopPropagation (Closed)

Created:
4 years, 1 month ago by Anton Obzhirov
Modified:
4 years ago
Reviewers:
tkent, hayato
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Event failed to dispatch after stopPropagation This patch implements step 14 of https://dom.spec.whatwg.org/#concept-event-dispatch BUG=656839 Committed: https://crrev.com/87e4a44094fe159ee1b311c1c784661d4d367f8f Cr-Commit-Position: refs/heads/master@{#434368}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated after review. #

Patch Set 3 : After format. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
D third_party/WebKit/LayoutTests/imported/wpt/dom/events/Event-dispatch-multiple-stopPropagation-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/imported/wpt/dom/events/Event-propagation-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/events/Event.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventDispatcher.cpp View 1 2 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 37 (19 generated)
Anton Obzhirov
On 2016/11/15 15:35:20, Anton Obzhirov wrote: > mailto:a.obzhirov@samsung.com changed reviewers: > + mailto:dominicc@chromium.org Plz have ...
4 years, 1 month ago (2016-11-15 15:36:05 UTC) #3
dominicc (has gone to gerrit)
On 2016/11/15 at 15:36:05, a.obzhirov wrote: > On 2016/11/15 15:35:20, Anton Obzhirov wrote: > > ...
4 years, 1 month ago (2016-11-17 03:07:07 UTC) #5
hayato
lgtm https://codereview.chromium.org/2501333003/diff/1/third_party/WebKit/Source/core/events/Event.h File third_party/WebKit/Source/core/events/Event.h (right): https://codereview.chromium.org/2501333003/diff/1/third_party/WebKit/Source/core/events/Event.h#newcode162 third_party/WebKit/Source/core/events/Event.h:162: void clearStopPropagation() { m_propagationStopped = false; } Could ...
4 years, 1 month ago (2016-11-17 05:37:42 UTC) #6
Anton Obzhirov
On 2016/11/17 05:37:42, hayato wrote: > lgtm > > https://codereview.chromium.org/2501333003/diff/1/third_party/WebKit/Source/core/events/Event.h > File third_party/WebKit/Source/core/events/Event.h (right): > ...
4 years, 1 month ago (2016-11-17 13:58:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501333003/20001
4 years, 1 month ago (2016-11-17 16:05:01 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/306979)
4 years, 1 month ago (2016-11-17 16:13:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501333003/20001
4 years, 1 month ago (2016-11-17 21:11:53 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/307424)
4 years, 1 month ago (2016-11-17 22:22:21 UTC) #16
Anton Obzhirov
Hi guys, I am not sure why it is failing chromium_presubmit - the logs don't ...
4 years, 1 month ago (2016-11-21 10:16:33 UTC) #17
tkent
On 2016/11/21 at 10:16:33, a.obzhirov wrote: > Hi guys, > > I am not sure ...
4 years, 1 month ago (2016-11-21 12:41:07 UTC) #18
Anton Obzhirov
On 2016/11/21 12:41:07, tkent wrote: > On 2016/11/21 at 10:16:33, a.obzhirov wrote: > > Hi ...
4 years, 1 month ago (2016-11-21 14:40:24 UTC) #19
Anton Obzhirov
The patch has passed the dry run, so if there is no more comments I ...
4 years, 1 month ago (2016-11-22 10:09:53 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501333003/40001
4 years ago (2016-11-23 12:09:21 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/337609)
4 years ago (2016-11-23 14:25:34 UTC) #29
Anton Obzhirov
On 2016/11/23 14:25:34, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years ago (2016-11-24 16:31:59 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501333003/40001
4 years ago (2016-11-24 16:32:26 UTC) #32
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-24 18:46:11 UTC) #35
commit-bot: I haz the power
4 years ago (2016-11-24 18:50:22 UTC) #37
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/87e4a44094fe159ee1b311c1c784661d4d367f8f
Cr-Commit-Position: refs/heads/master@{#434368}

Powered by Google App Engine
This is Rietveld 408576698