Event failed to dispatch after stopPropagation

Event failed to dispatch after stopPropagation

This patch implements step 14 of
https://dom.spec.whatwg.org/#concept-event-dispatch

BUG=656839
Committed: https://crrev.com/87e4a44094fe159ee1b311c1c784661d4d367f8f
Cr-Commit-Position: refs/heads/master@{#434368}

[Anton Obzhirov, 2016-11-15 15:35:20]

Description was changed from

==========
Event failed to dispatch after stopPropagation

This patch implements step 14 of
https://dom.spec.whatwg.org/#concept-event-dispatch

BUG=656839
==========

to

==========
Event failed to dispatch after stopPropagation

This patch implements step 14 of
https://dom.spec.whatwg.org/#concept-event-dispatch

BUG=656839
==========

[Anton Obzhirov, 2016-11-15 15:35:20]

a.obzhirov@samsung.com changed reviewers:
+ dominicc@chromium.org

[Anton Obzhirov, 2016-11-15 15:36:05]

On 2016/11/15 15:35:20, Anton Obzhirov wrote:
> mailto:a.obzhirov@samsung.com changed reviewers:
> + mailto:dominicc@chromium.org

Plz have a look.

[dominicc (has gone to gerrit), 2016-11-17 03:06:54]

dominicc@chromium.org changed reviewers:
+ hayato@chromium.org
- dominicc@chromium.org

[dominicc (has gone to gerrit), 2016-11-17 03:07:07]

On 2016/11/15 at 15:36:05, a.obzhirov wrote:
> On 2016/11/15 15:35:20, Anton Obzhirov wrote:
> > mailto:a.obzhirov@samsung.com changed reviewers:
> > + mailto:dominicc@chromium.org
> 
> Plz have a look.

hayato is a good reviewer for event related stuff.

[hayato, 2016-11-17 05:37:42]

lgtm

https://codereview.chromium.org/2501333003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/events/Event.h (right):

https://codereview.chromium.org/2501333003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/Event.h:162: void clearStopPropagation() {
m_propagationStopped = false; }
Could you rename this to setPropagationStopped(bool) for the consistency within
this file?

https://codereview.chromium.org/2501333003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/events/EventDispatcher.cpp (right):

https://codereview.chromium.org/2501333003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/EventDispatcher.cpp:257: // 14. Unset
event’s dispatch flag, stop propagation flag, and stop immediate propagation
flag.
Could you reorder [16, 15, 14] to [14, 15, 16]?

[Anton Obzhirov, 2016-11-17 13:58:52]

On 2016/11/17 05:37:42, hayato wrote:
> lgtm
> 
>
https://codereview.chromium.org/2501333003/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/events/Event.h (right):
> 
>
https://codereview.chromium.org/2501333003/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/events/Event.h:162: void clearStopPropagation()
{
> m_propagationStopped = false; }
> Could you rename this to setPropagationStopped(bool) for the consistency
within
> this file?
> 
>
https://codereview.chromium.org/2501333003/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/events/EventDispatcher.cpp (right):
> 
>
https://codereview.chromium.org/2501333003/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/events/EventDispatcher.cpp:257: // 14. Unset
> event’s dispatch flag, stop propagation flag, and stop immediate propagation
> flag.
> Could you reorder [16, 15, 14] to [14, 15, 16]?

Thanks for review, will address all issues.

[Anton Obzhirov, 2016-11-17 16:04:23]

The CQ bit was checked by a.obzhirov@samsung.com

[Anton Obzhirov, 2016-11-17 16:04:24]

The patchset sent to the CQ was uploaded after l-g-t-m from hayato@chromium.org
Link to the patchset: https://codereview.chromium.org/2501333003/#ps20001
(title: "Updated after review.")

[commit-bot: I haz the power, 2016-11-17 16:05:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 16:13:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 16:13:30]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tkent, 2016-11-17 21:10:38]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-11-17 21:11:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 22:22:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 22:22:21]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Anton Obzhirov, 2016-11-21 10:16:33]

Hi guys,

I am not sure why it is failing chromium_presubmit - the logs don't show any
errors. Is it because it requires second lgtm?

[tkent, 2016-11-21 12:41:07]

On 2016/11/21 at 10:16:33, a.obzhirov wrote:
> Hi guys,
> 
> I am not sure why it is failing chromium_presubmit - the logs don't show any
errors. Is it because it requires second lgtm?

The log shows a warning.
https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presu...
> ** Presubmit Warnings **
> The WebKit directory requires source formatting. Please run git cl format
third_party/WebKit

[Anton Obzhirov, 2016-11-21 14:40:24]

On 2016/11/21 12:41:07, tkent wrote:
> On 2016/11/21 at 10:16:33, a.obzhirov wrote:
> > Hi guys,
> > 
> > I am not sure why it is failing chromium_presubmit - the logs don't show any
> errors. Is it because it requires second lgtm?
> 
> The log shows a warning.
>
https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presu...
> > ** Presubmit Warnings **
> > The WebKit directory requires source formatting. Please run git cl format
> third_party/WebKit

Thanks for the hint, I have not realised warnings are mandatory for presubmit
checks.
Will upload the updated patch.

[Anton Obzhirov, 2016-11-21 15:27:32]

The CQ bit was checked by a.obzhirov@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 15:27:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 18:09:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 18:09:37]

Dry run: This issue passed the CQ dry run.

[Anton Obzhirov, 2016-11-22 10:09:53]

The patch has passed the dry run, so if there is no more comments I am going to
merge it today and close the bug.

[Anton Obzhirov, 2016-11-23 12:09:12]

The CQ bit was checked by a.obzhirov@samsung.com

[Anton Obzhirov, 2016-11-23 12:09:13]

The patchset sent to the CQ was uploaded after l-g-t-m from hayato@chromium.org
Link to the patchset: https://codereview.chromium.org/2501333003/#ps40001
(title: "After format.")

[commit-bot: I haz the power, 2016-11-23 12:09:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 14:25:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 14:25:34]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Anton Obzhirov, 2016-11-24 16:31:59]

On 2016/11/23 14:25:34, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

I've checked the failures, they shouldn't be related to the patch,
I will try again and if it fails may be will try to setup win build locally.

[Anton Obzhirov, 2016-11-24 16:32:12]

The CQ bit was checked by a.obzhirov@samsung.com

[commit-bot: I haz the power, 2016-11-24 16:32:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 18:45:46]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480005132310080,
"parent_rev": "e690e240df2846780f5f37f41974765c420cba88", "commit_rev":
"627a8a67f7986c231319672bfacf4402d1092078"}

[commit-bot: I haz the power, 2016-11-24 18:46:10]

Description was changed from

==========
Event failed to dispatch after stopPropagation

This patch implements step 14 of
https://dom.spec.whatwg.org/#concept-event-dispatch

BUG=656839
==========

to

==========
Event failed to dispatch after stopPropagation

This patch implements step 14 of
https://dom.spec.whatwg.org/#concept-event-dispatch

BUG=656839
==========

[commit-bot: I haz the power, 2016-11-24 18:46:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-24 18:50:21]

Description was changed from

==========
Event failed to dispatch after stopPropagation

This patch implements step 14 of
https://dom.spec.whatwg.org/#concept-event-dispatch

BUG=656839
==========

to

==========
Event failed to dispatch after stopPropagation

This patch implements step 14 of
https://dom.spec.whatwg.org/#concept-event-dispatch

BUG=656839

Committed: https://crrev.com/87e4a44094fe159ee1b311c1c784661d4d367f8f
Cr-Commit-Position: refs/heads/master@{#434368}
==========

[commit-bot: I haz the power, 2016-11-24 18:50:22]

Patchset 3 (id:??) landed as
https://crrev.com/87e4a44094fe159ee1b311c1c784661d4d367f8f
Cr-Commit-Position: refs/heads/master@{#434368}