Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: third_party/WebKit/Source/core/frame/Window.idl

Issue 2501333002: binding: Makes window/frames/self attributes return itself. (Closed)
Patch Set: Completely stopped using cached accessors. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/frame/DOMWindow.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/Window.idl
diff --git a/third_party/WebKit/Source/core/frame/Window.idl b/third_party/WebKit/Source/core/frame/Window.idl
index 2aa3ae7ccb1f5de681d1216b82a559b9c2e5ff25..3b935ce5bf01a522043c7d20108a043a9066e9c0 100644
--- a/third_party/WebKit/Source/core/frame/Window.idl
+++ b/third_party/WebKit/Source/core/frame/Window.idl
@@ -34,8 +34,8 @@
] interface Window : EventTarget {
// the current browsing context
// FIXME: The spec uses the WindowProxy type for this and many other attributes.
- [Unforgeable, DoNotCheckSecurity] readonly attribute Window window;
- [Replaceable, DoNotCheckSecurity] readonly attribute Window self;
+ [Unforgeable, CallWith=ScriptState, DoNotCheckSecurity] readonly attribute Window window;
+ [Replaceable, CallWith=ScriptState, DoNotCheckSecurity] readonly attribute Window self;
[Unforgeable, CachedAccessor] readonly attribute Document document;
attribute DOMString name;
[PutForwards=href, Unforgeable, DoNotCheckSecurity] readonly attribute Location location;
@@ -54,7 +54,7 @@
[DoNotCheckSecurity] void blur();
// other browsing contexts
- [Replaceable, DoNotCheckSecurity] readonly attribute Window frames;
+ [Replaceable, CallWith=ScriptState, DoNotCheckSecurity] readonly attribute Window frames;
[Replaceable, DoNotCheckSecurity] readonly attribute unsigned long length;
[Unforgeable, DoNotCheckSecurity] readonly attribute Window top;
// FIXME: opener should be of type any.
« no previous file with comments | « third_party/WebKit/Source/core/frame/DOMWindow.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698