Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: third_party/WebKit/Source/core/frame/DOMWindow.h

Issue 2501333002: binding: Makes window/frames/self attributes return itself. (Closed)
Patch Set: Completely stopped using cached accessors. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/DOMWindow.h
diff --git a/third_party/WebKit/Source/core/frame/DOMWindow.h b/third_party/WebKit/Source/core/frame/DOMWindow.h
index 128b40a608e5eb4745d36691ce2448d0bda04315..832d784206214a1ce92f1944ba4af9cd6e8fc395 100644
--- a/third_party/WebKit/Source/core/frame/DOMWindow.h
+++ b/third_party/WebKit/Source/core/frame/DOMWindow.h
@@ -114,9 +114,13 @@ class CORE_EXPORT DOMWindow : public EventTargetWithInlineData,
virtual void setDefaultStatus(const String&) = 0;
// Self-referential attributes
- DOMWindow* self() const;
- DOMWindow* window() const { return self(); }
- DOMWindow* frames() const { return self(); }
+ v8::Local<v8::Object> self(ScriptState*) const;
+ v8::Local<v8::Object> window(ScriptState* scriptState) const {
+ return self(scriptState);
+ }
+ v8::Local<v8::Object> frames(ScriptState* scriptState) const {
+ return self(scriptState);
+ }
DOMWindow* opener() const;
DOMWindow* parent() const;
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8Binding.h ('k') | third_party/WebKit/Source/core/frame/DOMWindow.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698