Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2501323002: Add missing include of errno.h (Closed)

Created:
4 years, 1 month ago by hugoh_UTC2
Modified:
4 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing include of errno.h This allows us to build the object file independently. BUG=none Committed: https://crrev.com/ff77e1a2b2b0b31e206e294c9171310d85c7dc3c Cr-Commit-Position: refs/heads/master@{#432459}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M net/quic/quartc/quartc_packet_writer.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
hugoh_UTC2
@zhihuang, I added a missing include. We need this, otherwise compilation stops as it misses ...
4 years, 1 month ago (2016-11-15 11:35:42 UTC) #3
zhihuang1
lgtm. Adding Ryan to approve this.
4 years, 1 month ago (2016-11-15 18:39:05 UTC) #5
Ryan Hamilton
lgtm
4 years, 1 month ago (2016-11-16 04:26:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501323002/1
4 years, 1 month ago (2016-11-16 08:59:37 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/273386)
4 years, 1 month ago (2016-11-16 11:00:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501323002/1
4 years, 1 month ago (2016-11-16 11:05:53 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 11:25:41 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 11:27:37 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff77e1a2b2b0b31e206e294c9171310d85c7dc3c
Cr-Commit-Position: refs/heads/master@{#432459}

Powered by Google App Engine
This is Rietveld 408576698