Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2501303002: [heap-verify] Allow for temporary invalid array length for slow elements (Closed)

Created:
4 years, 1 month ago by Camillo Bruni
Modified:
4 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap-verify] Allow for temporary invalid array length for slow elements R=jkummerow@chromium.org BUG=chromium:665112 Committed: https://crrev.com/3a91f8af1aaa096c7042e2f4105802badf7dab3e Cr-Commit-Position: refs/heads/master@{#41002}

Patch Set 1 #

Patch Set 2 : fix variable name #

Patch Set 3 : fixing of by one #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M src/objects-debug.cc View 1 2 1 chunk +12 lines, -5 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
Camillo Bruni
PTAL
4 years, 1 month ago (2016-11-15 09:51:06 UTC) #1
Jakob Kummerow
lgtm
4 years, 1 month ago (2016-11-15 10:06:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501303002/1
4 years, 1 month ago (2016-11-15 13:08:01 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/16244) v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED, ...
4 years, 1 month ago (2016-11-15 13:13:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501303002/40001
4 years, 1 month ago (2016-11-15 16:06:11 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501303002/40001
4 years, 1 month ago (2016-11-15 16:06:29 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-15 16:09:30 UTC) #21
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:34:38 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3a91f8af1aaa096c7042e2f4105802badf7dab3e
Cr-Commit-Position: refs/heads/master@{#41002}

Powered by Google App Engine
This is Rietveld 408576698