Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2501293002: Update a test to verify that Touch Events are composed events (Closed)

Created:
4 years, 1 month ago by hayato
Modified:
4 years, 1 month ago
Reviewers:
kochi
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update a test to verify that Touch Events are composed events Blink is missing a test for Touch Events. Committed: https://crrev.com/0ecb3ae49fa854a335331351fc54a8dc83dbb32e Cr-Commit-Position: refs/heads/master@{#432735}

Patch Set 1 #

Patch Set 2 : add a expected txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/fast/events/touch/basic-single-touch-events.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/touch/basic-single-touch-events-expected.txt View 1 4 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/shadow-dom/event-composed-ua.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
hayato
PTAL
4 years, 1 month ago (2016-11-15 07:00:28 UTC) #5
kochi
Why basic-single-touch-events.html failing for win_chromium_rel_ng? Any missing dependent CLs?
4 years, 1 month ago (2016-11-15 08:18:34 UTC) #8
hayato
add a expected txt
4 years, 1 month ago (2016-11-16 11:23:51 UTC) #9
hayato
I forgot to upload the expected-text. :( Done.
4 years, 1 month ago (2016-11-16 11:24:49 UTC) #12
kochi
On 2016/11/16 11:24:49, hayato wrote: > I forgot to upload the expected-text. :( > > ...
4 years, 1 month ago (2016-11-17 03:34:07 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501293002/20001
4 years, 1 month ago (2016-11-17 03:49:15 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-17 04:07:06 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 04:11:03 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0ecb3ae49fa854a335331351fc54a8dc83dbb32e
Cr-Commit-Position: refs/heads/master@{#432735}

Powered by Google App Engine
This is Rietveld 408576698