Refactor field_trial.cc

Refactor field_trial.cc

This change does three things:
1) removes the <handle>,<length> switch on the command line on Windows, since
   we are now using a static size.
2) creates CreateTrialsFromWindowsHandle(), which CreateTrialsFromCommandLine()
   will call, and makes CreateTrialsFromCommandLine more symmetric. We will probably
   do something similar for linux and mac
3) typedefs SharedPersistentMemoryAllocator::Reference and SharedPersistentMemoryAllocator
   to FieldTrial::FieldTrialRef and FieldTrialList::FieldTrialAllocator respectively.

BUG=665247
Committed: https://crrev.com/cc8319b4398e1568d6ea270f74f4fa0146cd455c
Cr-Commit-Position: refs/heads/master@{#433264}

[lawrencewu, 2016-11-15 16:41:31]

Description was changed from

==========
Refactor field_trial.cc

This change does mainly three things:
1) removes the <handle>,<length> switch on the command line on Windows, since
   we are now using a static size.
2) creates CreateTrialsFromWindowsHandle(), which CreateTrialsFromCommandLine()
   will call, and makes CreateTrialsFromCommandLine more symmetric. We will
probably
   do something similar for linux
3) typedefs SharedPersistentMemoryAllocator::Reference and
SharedPersistentMemoryAllocator
   to FieldTrial::FieldTrialRef and FieldTrialList::FieldTrialAllocator
respectively.

BUG=665247
==========

to

==========
Refactor field_trial.cc

This change does mainly three things:
1) removes the <handle>,<length> switch on the command line on Windows, since
   we are now using a static size.
2) creates CreateTrialsFromWindowsHandle(), which CreateTrialsFromCommandLine()
   will call, and makes CreateTrialsFromCommandLine more symmetric. We will
probably
   do something similar for linux and mac
3) typedefs SharedPersistentMemoryAllocator::Reference and
SharedPersistentMemoryAllocator
   to FieldTrial::FieldTrialRef and FieldTrialList::FieldTrialAllocator
respectively.

BUG=665247
==========

[lawrencewu, 2016-11-15 17:02:02]

lawrencewu@chromium.org changed reviewers:
+ asvitkine@chromium.org

[lawrencewu, 2016-11-15 17:02:03]

We should probably land this after fixing the crashing issue.

[lawrencewu, 2016-11-15 18:28:17]

Description was changed from

==========
Refactor field_trial.cc

This change does mainly three things:
1) removes the <handle>,<length> switch on the command line on Windows, since
   we are now using a static size.
2) creates CreateTrialsFromWindowsHandle(), which CreateTrialsFromCommandLine()
   will call, and makes CreateTrialsFromCommandLine more symmetric. We will
probably
   do something similar for linux and mac
3) typedefs SharedPersistentMemoryAllocator::Reference and
SharedPersistentMemoryAllocator
   to FieldTrial::FieldTrialRef and FieldTrialList::FieldTrialAllocator
respectively.

BUG=665247
==========

to

==========
Refactor field_trial.cc

This change does three things:
1) removes the <handle>,<length> switch on the command line on Windows, since
   we are now using a static size.
2) creates CreateTrialsFromWindowsHandle(), which CreateTrialsFromCommandLine()
   will call, and makes CreateTrialsFromCommandLine more symmetric. We will
probably
   do something similar for linux and mac
3) typedefs SharedPersistentMemoryAllocator::Reference and
SharedPersistentMemoryAllocator
   to FieldTrial::FieldTrialRef and FieldTrialList::FieldTrialAllocator
respectively.

BUG=665247
==========

[Alexei Svitkine (slow), 2016-11-16 01:55:13]

lgtm

https://codereview.chromium.org/2501283002/diff/40001/base/metrics/field_tria...
File base/metrics/field_trial.cc (right):

https://codereview.chromium.org/2501283002/diff/40001/base/metrics/field_tria...
base/metrics/field_trial.cc:822: SharedMemoryHandle(handle, GetCurrentProcId());
Nit: SharedMemoryHandle shm_handle(andle, GetCurrentProcId());

[lawrencewu, 2016-11-18 15:27:30]

Just gonna commit now actually, since it looks like the fix for the other bug
will take a bit longer to land.

On 2016/11/16 01:55:13, Alexei Svitkine (very slow) wrote:
> lgtm
> 
>
https://codereview.chromium.org/2501283002/diff/40001/base/metrics/field_tria...
> File base/metrics/field_trial.cc (right):
> 
>
https://codereview.chromium.org/2501283002/diff/40001/base/metrics/field_tria...
> base/metrics/field_trial.cc:822: SharedMemoryHandle(handle,
GetCurrentProcId());
> Nit: SharedMemoryHandle shm_handle(andle, GetCurrentProcId());

[lawrencewu, 2016-11-18 15:27:41]

The CQ bit was checked by lawrencewu@chromium.org

[lawrencewu, 2016-11-18 15:27:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2501283002/#ps80001
(title: "git rebase-update")

[commit-bot: I haz the power, 2016-11-18 15:28:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 18:38:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 18:38:18]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[lawrencewu, 2016-11-18 18:39:29]

The CQ bit was checked by lawrencewu@chromium.org

[commit-bot: I haz the power, 2016-11-18 18:40:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 19:34:50]

Description was changed from

==========
Refactor field_trial.cc

This change does three things:
1) removes the <handle>,<length> switch on the command line on Windows, since
   we are now using a static size.
2) creates CreateTrialsFromWindowsHandle(), which CreateTrialsFromCommandLine()
   will call, and makes CreateTrialsFromCommandLine more symmetric. We will
probably
   do something similar for linux and mac
3) typedefs SharedPersistentMemoryAllocator::Reference and
SharedPersistentMemoryAllocator
   to FieldTrial::FieldTrialRef and FieldTrialList::FieldTrialAllocator
respectively.

BUG=665247
==========

to

==========
Refactor field_trial.cc

This change does three things:
1) removes the <handle>,<length> switch on the command line on Windows, since
   we are now using a static size.
2) creates CreateTrialsFromWindowsHandle(), which CreateTrialsFromCommandLine()
   will call, and makes CreateTrialsFromCommandLine more symmetric. We will
probably
   do something similar for linux and mac
3) typedefs SharedPersistentMemoryAllocator::Reference and
SharedPersistentMemoryAllocator
   to FieldTrial::FieldTrialRef and FieldTrialList::FieldTrialAllocator
respectively.

BUG=665247
==========

[commit-bot: I haz the power, 2016-11-18 19:34:51]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-18 19:37:13]

Description was changed from

==========
Refactor field_trial.cc

This change does three things:
1) removes the <handle>,<length> switch on the command line on Windows, since
   we are now using a static size.
2) creates CreateTrialsFromWindowsHandle(), which CreateTrialsFromCommandLine()
   will call, and makes CreateTrialsFromCommandLine more symmetric. We will
probably
   do something similar for linux and mac
3) typedefs SharedPersistentMemoryAllocator::Reference and
SharedPersistentMemoryAllocator
   to FieldTrial::FieldTrialRef and FieldTrialList::FieldTrialAllocator
respectively.

BUG=665247
==========

to

==========
Refactor field_trial.cc

This change does three things:
1) removes the <handle>,<length> switch on the command line on Windows, since
   we are now using a static size.
2) creates CreateTrialsFromWindowsHandle(), which CreateTrialsFromCommandLine()
   will call, and makes CreateTrialsFromCommandLine more symmetric. We will
probably
   do something similar for linux and mac
3) typedefs SharedPersistentMemoryAllocator::Reference and
SharedPersistentMemoryAllocator
   to FieldTrial::FieldTrialRef and FieldTrialList::FieldTrialAllocator
respectively.

BUG=665247

Committed: https://crrev.com/cc8319b4398e1568d6ea270f74f4fa0146cd455c
Cr-Commit-Position: refs/heads/master@{#433264}
==========

[commit-bot: I haz the power, 2016-11-18 19:37:14]

Patchset 5 (id:??) landed as
https://crrev.com/cc8319b4398e1568d6ea270f74f4fa0146cd455c
Cr-Commit-Position: refs/heads/master@{#433264}