Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1420)

Issue 2501263002: Indexed DB: Add removal date to webkit-prefixed alias deprecations (Closed)

Created:
4 years, 1 month ago by jsbell
Modified:
4 years, 1 month ago
Reviewers:
foolip, timvolodine
CC:
chromium-reviews, blink-reviews, jsbell+idb_chromium.org, android-webview-reviews_chromium.org, cmumford
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Indexed DB: Add removal date to webkit-prefixed alias deprecations Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/biC_Tz7UV5Y/X5752vTvAgAJ R=foolip@chromium.org BUG=665243 Committed: https://crrev.com/d39b9fedfbc9f9c8dacab292e0e8937fb0aea726 Cr-Commit-Position: refs/heads/master@{#432784}

Patch Set 1 #

Patch Set 2 : Remove android_webview expectation change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -98 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/everything-to-string-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/js/global-constructors-expected.txt View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/isolatedWorld/all-window-properties-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/isolatedWorld/all-window-prototypes-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/unprefix-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/unprefix-workers-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-compositor-worker-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 1 chunk +18 lines, -9 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
jsbell
foolip@ - please take a look?
4 years, 1 month ago (2016-11-15 17:19:59 UTC) #5
jsbell
I only noticed the android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt file via grepping. It does not seem necessary to pass ...
4 years, 1 month ago (2016-11-15 18:00:32 UTC) #6
foolip
On 2016/11/15 18:00:32, jsbell wrote: > I only noticed the > android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt > file via ...
4 years, 1 month ago (2016-11-15 19:17:28 UTC) #7
foolip
lgtm \o/
4 years, 1 month ago (2016-11-15 19:19:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501263002/1
4 years, 1 month ago (2016-11-15 20:41:21 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/304705)
4 years, 1 month ago (2016-11-15 20:53:20 UTC) #12
jsbell
timvolodine@ - can you review the android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt change and/or provide guidance on whether or not ...
4 years, 1 month ago (2016-11-15 21:06:33 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501263002/20001
4 years, 1 month ago (2016-11-17 00:28:51 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/339161)
4 years, 1 month ago (2016-11-17 02:18:47 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501263002/20001
4 years, 1 month ago (2016-11-17 04:23:06 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-17 06:41:44 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 06:44:41 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d39b9fedfbc9f9c8dacab292e0e8937fb0aea726
Cr-Commit-Position: refs/heads/master@{#432784}

Powered by Google App Engine
This is Rietveld 408576698