Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: components/plugins/renderer/webview_plugin.cc

Issue 2501213002: Drag-and-drop: dragSourceEndedAt, dragSourceSystemDragEnded (Closed)
Patch Set: Rebased. Added check for !GetWebWidget(). Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/test_runner/event_sender.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/plugins/renderer/webview_plugin.cc
diff --git a/components/plugins/renderer/webview_plugin.cc b/components/plugins/renderer/webview_plugin.cc
index 23a7d04800a96df671a444015be02735dcd2b05d..8d45c4201aed4e7b9429fc053c946a038c98455f 100644
--- a/components/plugins/renderer/webview_plugin.cc
+++ b/components/plugins/renderer/webview_plugin.cc
@@ -245,7 +245,9 @@ void WebViewPlugin::startDragging(blink::WebReferrerPolicy,
const WebImage&,
const WebPoint&) {
// Immediately stop dragging.
- web_view_->dragSourceSystemDragEnded();
+ DCHECK(web_view_->mainFrame()->isWebLocalFrame());
+ web_view_->mainFrame()->toWebLocalFrame()->frameWidget()->
tommycli 2016/11/15 01:25:00 I assume frameWidget() is never null right?
paulmeyer 2016/11/15 01:42:54 Right. It can never be null here.
+ dragSourceSystemDragEnded();
}
bool WebViewPlugin::allowsBrokenNullLayerTreeView() const {
« no previous file with comments | « no previous file | components/test_runner/event_sender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698