Drag-and-drop: dragSourceEndedAt, dragSourceSystemDragEnded

content/browser/browser_plugin/browser_plugin_guest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_plugin/browser_plugin_guest.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 
@@ skipping 491 matching lines @@
     // do not load external resources and so they load prior to attachment.
     // As a result, we must save all these IPCs until attachment and then
     // forward them so that the embedder gets a chance to see and process
     // the load events.
     pending_messages_.push_back(std::move(msg));
     return;
   }
   owner_web_contents_->Send(msg.release());
 }
 
-void BrowserPluginGuest::DragSourceEndedAt(int client_x, int client_y,
-    int screen_x, int screen_y, blink::WebDragOperation operation) {
-  web_contents()->GetRenderViewHost()->DragSourceEndedAt(client_x, client_y,
-      screen_x, screen_y, operation);
+void BrowserPluginGuest::DragSourceEndedAt(int client_x,
+                                           int client_y,
+                                           int screen_x,
+                                           int screen_y,
+                                           blink::WebDragOperation operation) {
+  // TODO(paulmeyer): This will need to target the correct specific
+  // RenderWidgetHost to work with OOPIFs. See crbug.com/647249.
+  web_contents()->GetRenderViewHost()->GetWidget()->DragSourceEndedAt(
+      client_x, client_y, screen_x, screen_y, operation);
   seen_embedder_drag_source_ended_at_ = true;
   EndSystemDragIfApplicable();
 }
 
 void BrowserPluginGuest::EndSystemDragIfApplicable() {
   // Ideally we'd want either WebDragStatusDrop or WebDragStatusLeave...
   // Call guest RVH->DragSourceSystemDragEnded() correctly on the guest where
   // the drag was initiated. Calling DragSourceSystemDragEnded() correctly
   // means we call it in all cases and also make sure we only call it once.
   // This ensures that the input state of the guest stays correct, otherwise
   // it will go stale and won't accept any further input events.
   //
   // The strategy used here to call DragSourceSystemDragEnded() on the RVH
   // is when the following conditions are met:
   //   a. Embedder has seen SystemDragEnded()
   //   b. Embedder has seen DragSourceEndedAt()
   //   c. The guest has seen some drag status update other than
   //      WebDragStatusUnknown. Note that this step should ideally be done
   //      differently: The guest has seen at least one of
   //      {WebDragStatusOver, WebDragStatusDrop}. However, if a user drags
   //      a source quickly outside of <webview> bounds, then the
   //      BrowserPluginGuest never sees any of these drag status updates,
   //      there we just check whether we've seen any drag status update or
   //      not.
   if (last_drag_status_ != blink::WebDragStatusOver &&
       seen_embedder_drag_source_ended_at_ && seen_embedder_system_drag_ended_) {
     RenderViewHostImpl* guest_rvh = static_cast<RenderViewHostImpl*>(
         GetWebContents()->GetRenderViewHost());
-    guest_rvh->DragSourceSystemDragEnded();
+    guest_rvh->GetWidget()->DragSourceSystemDragEnded();
     last_drag_status_ = blink::WebDragStatusUnknown;
     seen_embedder_system_drag_ended_ = false;
     seen_embedder_drag_source_ended_at_ = false;
     ignore_dragged_url_ = true;
   }
 }
 
 void BrowserPluginGuest::EmbedderSystemDragEnded() {
   seen_embedder_system_drag_ended_ = true;
   EndSystemDragIfApplicable();
@@ skipping 483 matching lines @@
           range, character_bounds);
 }
 #endif
 
 void BrowserPluginGuest::SetContextMenuPosition(const gfx::Point& position) {
   if (delegate_)
     delegate_->SetContextMenuPosition(position);
 }
 
 }  // namespace content