Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2880)

Unified Diff: base/android/java/src/org/chromium/base/CpuFeatures.java

Issue 2501193003: Selectively perform JNI registration in render processes on Android. (Closed)
Patch Set: Update NativeInit Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/java/src/org/chromium/base/CpuFeatures.java
diff --git a/base/android/java/src/org/chromium/base/CpuFeatures.java b/base/android/java/src/org/chromium/base/CpuFeatures.java
index ae4969c99ea0ecc70a9454987e0b871e9140f171..09cbdddf51413d61f120170a58a331f3a01f8a6c 100644
--- a/base/android/java/src/org/chromium/base/CpuFeatures.java
+++ b/base/android/java/src/org/chromium/base/CpuFeatures.java
@@ -5,21 +5,24 @@
package org.chromium.base;
import org.chromium.base.annotations.JNINamespace;
+import org.chromium.base.annotations.MainDex;
-// The only purpose of this class is to allow sending CPU properties
-// from the browser process to sandboxed renderer processes. This is
-// needed because sandboxed processes cannot, on ARM, query the kernel
-// about the CPU's properties by parsing /proc, so this operation must
-// be performed in the browser process, and the result passed to
-// renderer ones.
-//
-// For more context, see http://crbug.com/164154
-//
-// Technically, this is a wrapper around the native NDK cpufeatures
-// library. The exact CPU features bits are never used in Java so
-// there is no point in duplicating their definitions here.
-//
+/**
+ * The only purpose of this class is to allow sending CPU properties
+ * from the browser process to sandboxed renderer processes. This is
+ * needed because sandboxed processes cannot, on ARM, query the kernel
+ * about the CPU's properties by parsing /proc, so this operation must
+ * be performed in the browser process, and the result passed to
+ * renderer ones.
+ *
+ * For more context, see http://crbug.com/164154
+ *
+ * Technically, this is a wrapper around the native NDK cpufeatures
+ * library. The exact CPU features bits are never used in Java so
+ * there is no point in duplicating their definitions here.
+ */
@JNINamespace("base::android")
+@MainDex
Torne 2017/01/09 16:43:32 Might be cleaner to land the added @MainDex requir
estevenson 2017/01/12 03:46:49 Done.
public abstract class CpuFeatures {
/**
* Return the number of CPU Cores on the device.

Powered by Google App Engine
This is Rietveld 408576698