Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Side by Side Diff: chrome/browser/android/chrome_entry_point.cc

Issue 2501193003: Selectively perform JNI registration in render processes on Android. (Closed)
Patch Set: Address Ted C comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/android/jni_utils.cc ('k') | chrome/browser/android/monochrome_entry_point.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/android/jni_android.h" 5 #include "base/android/jni_android.h"
6 #include "base/android/jni_utils.h"
6 #include "base/android/library_loader/library_loader_hooks.h" 7 #include "base/android/library_loader/library_loader_hooks.h"
7 #include "base/bind.h" 8 #include "base/bind.h"
8 #include "chrome/app/android/chrome_jni_onload.h" 9 #include "chrome/app/android/chrome_jni_onload.h"
9 10
10 namespace { 11 namespace {
11 12
12 bool RegisterJNI(JNIEnv* env) { 13 bool RegisterJNI(JNIEnv* env) {
13 return true; 14 return true;
14 } 15 }
15 16
16 bool Init() { 17 bool Init() {
17 return true; 18 return true;
18 } 19 }
19 20
20 bool NativeInit() { 21 bool NativeInit() {
21 return android::OnJNIOnLoadInit(base::Bind(&Init)); 22 return android::OnJNIOnLoadInit(base::Bind(&Init));
22 } 23 }
23 24
24 } // namespace 25 } // namespace
25 26
26 // This is called by the VM when the shared library is first loaded. 27 // This is called by the VM when the shared library is first loaded.
27 JNI_EXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) { 28 JNI_EXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) {
29 // By default, all JNI methods are registered. However, since render processes
30 // don't need very much Java code, we enable selective JNI registration on the
31 // Java side and only register a subset of JNI methods.
32 base::android::InitVM(vm);
33 JNIEnv* env = base::android::AttachCurrentThread();
34 if (base::android::isSelectiveJniRegistrationEnabled(env)) {
35 base::android::SetJniRegistrationType(
36 base::android::SELECTIVE_JNI_REGISTRATION);
37 }
28 if (!android::OnJNIOnLoadRegisterJNI(vm, base::Bind(&RegisterJNI))) { 38 if (!android::OnJNIOnLoadRegisterJNI(vm, base::Bind(&RegisterJNI))) {
29 return -1; 39 return -1;
30 } 40 }
31 base::android::SetNativeInitializationHook(NativeInit); 41 base::android::SetNativeInitializationHook(NativeInit);
32 return JNI_VERSION_1_4; 42 return JNI_VERSION_1_4;
33 } 43 }
OLDNEW
« no previous file with comments | « base/android/jni_utils.cc ('k') | chrome/browser/android/monochrome_entry_point.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698