Selectively perform JNI registration in render processes on Android.

base/android/jni_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/android/jni_android.h"
 
 #include <stddef.h>
 
 #include <map>
 
 #include "base/android/build_info.h"
 #include "base/android/jni_string.h"
 #include "base/android/jni_utils.h"
+#include "base/android/library_loader/library_loader_hooks.h"
 #include "base/debug/debugging_flags.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/threading/thread_local.h"
 
 namespace {
 using base::android::GetClass;
 using base::android::MethodID;
 using base::android::ScopedJavaLocalRef;
 
-bool g_disable_manual_jni_registration = false;
+base::android::JniRegistrationType g_jni_registration_type =
+    base::android::UNINITIALIZED_JNI_REGISTRATION;
 
 JavaVM* g_jvm = NULL;
 base::LazyInstance<base::android::ScopedJavaGlobalRef<jobject> >::Leaky
     g_class_loader = LAZY_INSTANCE_INITIALIZER;
 jmethodID g_class_loader_load_class_method_id = 0;
 
 #if BUILDFLAG(ENABLE_PROFILING) && HAVE_TRACE_STACK_FRAME_POINTERS
 base::LazyInstance<base::ThreadLocalPointer<void>>::Leaky
     g_stack_frame_pointer = LAZY_INSTANCE_INITIALIZER;
 #endif
 
 }  // namespace
 
 namespace base {
 namespace android {
 
-bool IsManualJniRegistrationDisabled() {
-  return g_disable_manual_jni_registration;
+void InitJniRegistrationType(JNIEnv* env, bool force_registration) {

[Torne, 2017/01/12 13:48:06]

I assume you have force_registration here to handle the cases where
LibraryProcessType isn't set in time?

Maybe it'd be nicer to just skip the step of basing this on the process type at
all, and just have Java tell native what registration is required?

+  if (force_registration) {
+    g_jni_registration_type = ALL_JNI_REGISTRATION;
+    return;
+  }
+  DCHECK(g_jni_registration_type == UNINITIALIZED_JNI_REGISTRATION);
+  switch (GetLibraryProcessType(env)) {
+    case PROCESS_WEBVIEW:
+    case PROCESS_WEBVIEW_CHILD:
+      g_jni_registration_type = NO_JNI_REGISTRATION;
+      break;
+    case PROCESS_BROWSER:
+      g_jni_registration_type = ALL_JNI_REGISTRATION;
+      break;
+    case PROCESS_CHILD:
+      g_jni_registration_type = SELECTIVE_JNI_REGISTRATION;
+      break;
+    default:
+      NOTREACHED();
+  }
 }
 
-void DisableManualJniRegistration() {
-  DCHECK(!g_disable_manual_jni_registration);
-  g_disable_manual_jni_registration = true;
+JniRegistrationType GetJniRegistrationType() {
+  return g_jni_registration_type;
 }
 
 JNIEnv* AttachCurrentThread() {
   DCHECK(g_jvm);
   JNIEnv* env = NULL;
   jint ret = g_jvm->AttachCurrentThread(&env, NULL);
   DCHECK_EQ(JNI_OK, ret);
   return env;
 }
 
@@ skipping 243 matching lines @@
 }
 
 void* JNIStackFrameSaver::SavedFrame() {
   return g_stack_frame_pointer.Pointer()->Get();
 }
 
 #endif  // ENABLE_PROFILING && HAVE_TRACE_STACK_FRAME_POINTERS
 
 }  // namespace android
 }  // namespace base