third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl - Issue 2501163002: RTCPeerConnection: match createDataChannel signature in spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

Issue 2501163002: RTCPeerConnection: match createDataChannel signature in spec (Closed)

Patch Set: expand id tests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

index f7d0137b6c8e04bdc863e3a7f03c1eeeeaf7b6d8..47d1413cdcc11329261c21be028b1007c418b6a2 100644

--- a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

+++ b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

@@ -116,9 +116,7 @@ enum RTCIceConnectionState {

sequence<RTCRtpReceiver> getReceivers();

// https://w3c.github.io/webrtc-pc/#peer-to-peer-data-api

- // TODO(guidou): The label argument should have [TreatNullAs=EmptyString]

- // and be non-nullable.

- [CallWith=ScriptState, RaisesException] RTCDataChannel createDataChannel(DOMString? label, optional Dictionary options);

+ [CallWith=ScriptState, RaisesException] RTCDataChannel createDataChannel(USVString label, optional RTCDataChannelInit dataChannelDict);

attribute EventHandler ondatachannel;

// Certificate management

« no previous file with comments | « third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp ('k') | no next file » | no next file with comments »