third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h - Issue 2501163002: RTCPeerConnection: match createDataChannel signature in spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

Issue 2501163002: RTCPeerConnection: match createDataChannel signature in spec (Closed)

Patch Set: expand id tests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/peerconnection/RTCDataChannelInit.idl ('k') | third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

index ba4649860f11027b40fadb7e3712f526030b0108..651bbe726cdee59d212e8538cca30764d923e34e 100644

--- a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

+++ b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

@@ -53,6 +53,7 @@ class RTCAnswerOptions;

class RTCConfiguration;

class RTCDTMFSender;

class RTCDataChannel;

+class RTCDataChannelInit;

class RTCIceCandidateInitOrRTCIceCandidate;

class RTCOfferOptions;

class RTCPeerConnectionErrorCallback;

@@ -153,7 +154,7 @@ class RTCPeerConnection final : public EventTargetWithInlineData,

RTCDataChannel* createDataChannel(ScriptState*,

String label,

- const Dictionary& data_channel_dict,

+ const RTCDataChannelInit&,

ExceptionState&);

RTCDTMFSender* createDTMFSender(MediaStreamTrack*, ExceptionState&);