Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl

Issue 2501163002: RTCPeerConnection: match createDataChannel signature in spec (Closed)
Patch Set: expand id tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 [CallWith=ScriptState, LegacyInterfaceTypeChecking] Promise<void> getStats(R TCStatsCallback successCallback, optional MediaStreamTrack? selector); 109 [CallWith=ScriptState, LegacyInterfaceTypeChecking] Promise<void> getStats(R TCStatsCallback successCallback, optional MediaStreamTrack? selector);
110 // TODO(hbos): The spec has an optional |selector| argument that is not 110 // TODO(hbos): The spec has an optional |selector| argument that is not
111 // supported yet. There is a discussion about what to do with it (clarify 111 // supported yet. There is a discussion about what to do with it (clarify
112 // spec, remove it or change it?): https://github.com/w3c/webrtc-stats/issue s/116 112 // spec, remove it or change it?): https://github.com/w3c/webrtc-stats/issue s/116
113 [CallWith=ScriptState] Promise<RTCStatsReport> getStats(); 113 [CallWith=ScriptState] Promise<RTCStatsReport> getStats();
114 114
115 // https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-getreceivers 115 // https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-getreceivers
116 sequence<RTCRtpReceiver> getReceivers(); 116 sequence<RTCRtpReceiver> getReceivers();
117 117
118 // https://w3c.github.io/webrtc-pc/#peer-to-peer-data-api 118 // https://w3c.github.io/webrtc-pc/#peer-to-peer-data-api
119 // TODO(guidou): The label argument should have [TreatNullAs=EmptyString] 119 [CallWith=ScriptState, RaisesException] RTCDataChannel createDataChannel(USV String label, optional RTCDataChannelInit dataChannelDict);
120 // and be non-nullable.
121 [CallWith=ScriptState, RaisesException] RTCDataChannel createDataChannel(DOM String? label, optional Dictionary options);
122 attribute EventHandler ondatachannel; 120 attribute EventHandler ondatachannel;
123 121
124 // Certificate management 122 // Certificate management
125 // https://w3c.github.io/webrtc-pc/#sec.cert-mgmt 123 // https://w3c.github.io/webrtc-pc/#sec.cert-mgmt
126 [RaisesException, CallWith=ScriptState] static Promise<RTCCertificate> gener ateCertificate(AlgorithmIdentifier keygenAlgorithm); 124 [RaisesException, CallWith=ScriptState] static Promise<RTCCertificate> gener ateCertificate(AlgorithmIdentifier keygenAlgorithm);
127 125
128 // Non-standard or removed from the spec: 126 // Non-standard or removed from the spec:
129 [Measure] sequence<MediaStream> getLocalStreams(); 127 [Measure] sequence<MediaStream> getLocalStreams();
130 [Measure] sequence<MediaStream> getRemoteStreams(); 128 [Measure] sequence<MediaStream> getRemoteStreams();
131 [DeprecateAs=V8RTCPeerConnection_GetStreamById_Method] MediaStream getStream ById(DOMString streamId); 129 [DeprecateAs=V8RTCPeerConnection_GetStreamById_Method] MediaStream getStream ById(DOMString streamId);
132 [Measure, CallWith=ScriptState, RaisesException] void addStream(MediaStream? stream, optional Dictionary mediaConstraints); 130 [Measure, CallWith=ScriptState, RaisesException] void addStream(MediaStream? stream, optional Dictionary mediaConstraints);
133 [Measure, RaisesException] void removeStream(MediaStream? stream); 131 [Measure, RaisesException] void removeStream(MediaStream? stream);
134 [Measure, RaisesException] RTCDTMFSender createDTMFSender(MediaStreamTrack t rack); 132 [Measure, RaisesException] RTCDTMFSender createDTMFSender(MediaStreamTrack t rack);
135 attribute EventHandler onaddstream; 133 attribute EventHandler onaddstream;
136 attribute EventHandler onremovestream; 134 attribute EventHandler onremovestream;
137 }; 135 };
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698