Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

Issue 2501163002: RTCPeerConnection: match createDataChannel signature in spec (Closed)
Patch Set: expand id tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 #include "public/platform/WebRTCPeerConnectionHandler.h" 46 #include "public/platform/WebRTCPeerConnectionHandler.h"
47 #include "public/platform/WebRTCPeerConnectionHandlerClient.h" 47 #include "public/platform/WebRTCPeerConnectionHandlerClient.h"
48 48
49 namespace blink { 49 namespace blink {
50 class ExceptionState; 50 class ExceptionState;
51 class MediaStreamTrack; 51 class MediaStreamTrack;
52 class RTCAnswerOptions; 52 class RTCAnswerOptions;
53 class RTCConfiguration; 53 class RTCConfiguration;
54 class RTCDTMFSender; 54 class RTCDTMFSender;
55 class RTCDataChannel; 55 class RTCDataChannel;
56 class RTCDataChannelInit;
56 class RTCIceCandidateInitOrRTCIceCandidate; 57 class RTCIceCandidateInitOrRTCIceCandidate;
57 class RTCOfferOptions; 58 class RTCOfferOptions;
58 class RTCPeerConnectionErrorCallback; 59 class RTCPeerConnectionErrorCallback;
59 class RTCRtpReceiver; 60 class RTCRtpReceiver;
60 class RTCSessionDescription; 61 class RTCSessionDescription;
61 class RTCSessionDescriptionCallback; 62 class RTCSessionDescriptionCallback;
62 class RTCSessionDescriptionInit; 63 class RTCSessionDescriptionInit;
63 class RTCStatsCallback; 64 class RTCStatsCallback;
64 class ScriptState; 65 class ScriptState;
65 class VoidCallback; 66 class VoidCallback;
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 147
147 ScriptPromise getStats(ScriptState*, 148 ScriptPromise getStats(ScriptState*,
148 RTCStatsCallback* success_callback, 149 RTCStatsCallback* success_callback,
149 MediaStreamTrack* selector = nullptr); 150 MediaStreamTrack* selector = nullptr);
150 ScriptPromise getStats(ScriptState*); 151 ScriptPromise getStats(ScriptState*);
151 152
152 HeapVector<Member<RTCRtpReceiver>> getReceivers(); 153 HeapVector<Member<RTCRtpReceiver>> getReceivers();
153 154
154 RTCDataChannel* createDataChannel(ScriptState*, 155 RTCDataChannel* createDataChannel(ScriptState*,
155 String label, 156 String label,
156 const Dictionary& data_channel_dict, 157 const RTCDataChannelInit&,
157 ExceptionState&); 158 ExceptionState&);
158 159
159 RTCDTMFSender* createDTMFSender(MediaStreamTrack*, ExceptionState&); 160 RTCDTMFSender* createDTMFSender(MediaStreamTrack*, ExceptionState&);
160 161
161 void close(ExceptionState&); 162 void close(ExceptionState&);
162 163
163 // We allow getStats after close, but not other calls or callbacks. 164 // We allow getStats after close, but not other calls or callbacks.
164 bool ShouldFireDefaultCallbacks() { return !closed_ && !stopped_; } 165 bool ShouldFireDefaultCallbacks() { return !closed_ && !stopped_; }
165 bool ShouldFireGetStatsCallback() { return !stopped_; } 166 bool ShouldFireGetStatsCallback() { return !stopped_; }
166 167
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
272 273
273 bool stopped_; 274 bool stopped_;
274 bool closed_; 275 bool closed_;
275 276
276 bool has_data_channels_; // For RAPPOR metrics 277 bool has_data_channels_; // For RAPPOR metrics
277 }; 278 };
278 279
279 } // namespace blink 280 } // namespace blink
280 281
281 #endif // RTCPeerConnection_h 282 #endif // RTCPeerConnection_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698