Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3575)

Unified Diff: chrome/android/BUILD.gn

Issue 2501153002: Build public monochrome (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/chrome_public_apk_tmpl.gni » ('j') | chrome/android/java/templates/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/BUILD.gn
diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
index 50ccd560ac4b85f540220259c367114187f3c875..db9ce38fac90c996f992a1773250587e20b68c97 100644
--- a/chrome/android/BUILD.gn
+++ b/chrome/android/BUILD.gn
@@ -8,6 +8,7 @@ import("//build/config/android/rules.gni")
import("//build/util/process_version.gni")
import("//build_overrides/v8.gni")
import("//chrome/android/chrome_public_apk_tmpl.gni")
+import("//chrome/android/monochrome_android_manifest_jinja_variables.gni")
import("//chrome/chrome_paks.gni")
import("//chrome/common/features.gni")
import("//chrome/process_version_rc_template.gni") # For branding_file_path.
@@ -28,6 +29,8 @@ chrome_modern_public_android_manifest =
"$target_gen_dir/chrome_modern_public_apk/AndroidManifest.xml"
chrome_sync_shell_android_manifest =
"$target_gen_dir/chrome_sync_shell_apk/AndroidManifest.xml"
+monochrome_public_android_manifest =
+ "$target_gen_dir/monochrome_public_apk/AndroidManifest.xml"
chrome_sync_shell_jinja_variables =
default_chrome_public_jinja_variables +
@@ -58,6 +61,14 @@ jinja_template("chrome_modern_public_android_manifest") {
]
}
+jinja_template("monochrome_public_android_manifest") {
+ input = "java/AndroidManifest_monochrome.xml"
+ output = monochrome_public_android_manifest
+ variables =
+ chrome_public_jinja_variables +
+ monochrome_android_manifest_jinja_variables + [ "target_sdk_version=24" ]
+}
+
java_cpp_template("chrome_webapk_signature_srcjar") {
sources = [
"java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHostSignature.template",
@@ -686,6 +697,18 @@ chrome_public_apk_tmpl_shared("chrome_modern_public_apk") {
load_library_from_apk = chromium_linker_supported
}
+monochrome_public_apk_tmpl("monochrome_public_apk") {
+ android_manifest = monochrome_public_android_manifest
+ android_manifest_dep = ":monochrome_public_android_manifest"
+ apk_name = "MonochromePublic"
+
+ deps = [
+ "//base:base_java",
agrieve 2016/11/14 21:19:24 I'd guess we don't need a direct dep on base_java?
michaelbai 2016/11/14 22:36:35 We need it, here is error without it /tmp/tmp0ZC
+ "//chrome/android:chrome_java",
+ "//chrome/android/java/templates:public_monochrome_java",
+ ]
+}
+
chrome_public_apk_tmpl_shared("chrome_sync_shell_apk") {
testonly = true
android_manifest = chrome_sync_shell_android_manifest
« no previous file with comments | « no previous file | chrome/android/chrome_public_apk_tmpl.gni » ('j') | chrome/android/java/templates/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698