Build public monochrome

Build public monochrome

BUG=650927
Committed: https://crrev.com/2bad11a0781e999dffc9f2953304689b17de5e6d
Cr-Commit-Position: refs/heads/master@{#432058}

[michaelbai, 2016-11-14 20:17:33]

Description was changed from

==========
Build public monochrome

BUG=650927
==========

to

==========
Build public monochrome

BUG=650927
==========

[michaelbai, 2016-11-14 20:17:33]

michaelbai@chromium.org changed reviewers:
+ agrieve@chromium.org

[michaelbai, 2016-11-14 20:31:10]

The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 20:32:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[agrieve, 2016-11-14 21:19:24]

I don't love the template for MonochromeApplication, but I also don't see a
great alternative :(. If I think of one, we can always iterate. lgtm!

https://codereview.chromium.org/2501153002/diff/1/chrome/android/BUILD.gn
File chrome/android/BUILD.gn (right):

https://codereview.chromium.org/2501153002/diff/1/chrome/android/BUILD.gn#new...
chrome/android/BUILD.gn:706: "//base:base_java",
I'd guess we don't need a direct dep on base_java?

https://codereview.chromium.org/2501153002/diff/1/chrome/android/java/templat...
File chrome/android/java/templates/BUILD.gn (right):

https://codereview.chromium.org/2501153002/diff/1/chrome/android/java/templat...
chrome/android/java/templates/BUILD.gn:1: # Copyright (c) 2016 The Chromium
Authors. All rights reserved.
nit: zap the (c)

https://codereview.chromium.org/2501153002/diff/1/chrome/android/java/templat...
File chrome/android/java/templates/monochrome_application.gni (right):

https://codereview.chromium.org/2501153002/diff/1/chrome/android/java/templat...
chrome/android/java/templates/monochrome_application.gni:1: # Copyright (c) 2016
The Chromium Authors. All rights reserved.
zap!

[commit-bot: I haz the power, 2016-11-14 21:28:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 21:28:23]

Dry run: This issue passed the CQ dry run.

[michaelbai, 2016-11-14 22:36:35]

Right, that template is not perfect, we should replace it if there is better
one.

https://codereview.chromium.org/2501153002/diff/1/chrome/android/BUILD.gn
File chrome/android/BUILD.gn (right):

https://codereview.chromium.org/2501153002/diff/1/chrome/android/BUILD.gn#new...
chrome/android/BUILD.gn:706: "//base:base_java",
On 2016/11/14 21:19:24, agrieve wrote:
> I'd guess we don't need a direct dep on base_java?

We need it, here is error without it 

/tmp/tmp0ZCuAi/java/org/chromium/base/library_loader/NativeLibraries.java:2:
error: package org.chromium.base.annotations does not exist
import org.chromium.base.annotations.SuppressFBWarnings;
                                    ^
/tmp/tmp0ZCuAi/java/org/chromium/base/library_loader/NativeLibraries.java:3:
error: cannot find symbol
@SuppressFBWarnings
 ^
  symbol: class SuppressFBWarnings
2 errors

https://codereview.chromium.org/2501153002/diff/1/chrome/android/java/templat...
File chrome/android/java/templates/BUILD.gn (right):

https://codereview.chromium.org/2501153002/diff/1/chrome/android/java/templat...
chrome/android/java/templates/BUILD.gn:1: # Copyright (c) 2016 The Chromium
Authors. All rights reserved.
On 2016/11/14 21:19:24, agrieve wrote:
> nit: zap the (c)

Done.

https://codereview.chromium.org/2501153002/diff/1/chrome/android/java/templat...
File chrome/android/java/templates/monochrome_application.gni (right):

https://codereview.chromium.org/2501153002/diff/1/chrome/android/java/templat...
chrome/android/java/templates/monochrome_application.gni:1: # Copyright (c) 2016
The Chromium Authors. All rights reserved.
On 2016/11/14 21:19:24, agrieve wrote:
> zap!

Done.

[michaelbai, 2016-11-14 22:36:44]

The CQ bit was checked by michaelbai@chromium.org

[michaelbai, 2016-11-14 22:36:45]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2501153002/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2016-11-14 22:39:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 22:55:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 22:55:54]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[michaelbai, 2016-11-14 22:58:37]

michaelbai@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[michaelbai, 2016-11-14 22:59:19]

dfalcantara@ for owner approval

[gone, 2016-11-14 23:07:12]

rs lgtm

[michaelbai, 2016-11-15 00:55:55]

The CQ bit was checked by michaelbai@chromium.org

[commit-bot: I haz the power, 2016-11-15 00:56:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 02:12:12]

Description was changed from

==========
Build public monochrome

BUG=650927
==========

to

==========
Build public monochrome

BUG=650927
==========

[commit-bot: I haz the power, 2016-11-15 02:12:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-15 03:00:53]

Description was changed from

==========
Build public monochrome

BUG=650927
==========

to

==========
Build public monochrome

BUG=650927

Committed: https://crrev.com/2bad11a0781e999dffc9f2953304689b17de5e6d
Cr-Commit-Position: refs/heads/master@{#432058}
==========

[commit-bot: I haz the power, 2016-11-15 03:00:54]

Patchset 2 (id:??) landed as
https://crrev.com/2bad11a0781e999dffc9f2953304689b17de5e6d
Cr-Commit-Position: refs/heads/master@{#432058}