Disable the old lock-screen shortcut

Disable the old lock-screen shortcut

Disbale the shortcut but keeps the notification for another milestone.

BUG=612990
TEST=ash_unittests --gtest_filter=AcceleratorControllerTest.*
TEST=ash_unittests --gtest_filter=DeprecatedAcceleratorTester.*

Committed: https://crrev.com/1b1e927b139a713c966719345846631e0e72f308
Cr-Commit-Position: refs/heads/master@{#431946}

[afakhry, 2016-11-14 19:54:38]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 20:01:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 21:18:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 21:18:22]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[afakhry, 2016-11-14 21:59:03]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[afakhry, 2016-11-14 22:00:13]

afakhry@chromium.org changed reviewers:
+ jamescook@chromium.org

[afakhry, 2016-11-14 22:00:13]

James, can you please review this CL? Thanks!

[commit-bot: I haz the power, 2016-11-14 22:00:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-11-14 22:09:10]

LGTM

https://codereview.chromium.org/2501123002/diff/20001/ash/common/accelerators...
File ash/common/accelerators/accelerator_table.cc (right):

https://codereview.chromium.org/2501123002/diff/20001/ash/common/accelerators...
ash/common/accelerators/accelerator_table.cc:222: false  // Old accelerator was
disabled in M56.
I like how you mentioned the milestone in the comment. It makes it much easier
for later readers to figure out when it can be totally removed.

[afakhry, 2016-11-14 22:48:19]

The CQ bit was unchecked by afakhry@chromium.org

[afakhry, 2016-11-14 22:48:22]

The CQ bit was checked by afakhry@chromium.org

[afakhry, 2016-11-14 22:48:47]

https://codereview.chromium.org/2501123002/diff/20001/ash/common/accelerators...
File ash/common/accelerators/accelerator_table.cc (right):

https://codereview.chromium.org/2501123002/diff/20001/ash/common/accelerators...
ash/common/accelerators/accelerator_table.cc:222: false  // Old accelerator was
disabled in M56.
On 2016/11/14 22:09:10, James Cook wrote:
> I like how you mentioned the milestone in the comment. It makes it much easier
> for later readers to figure out when it can be totally removed.

Thanks! That was the intent. :)

[commit-bot: I haz the power, 2016-11-14 22:50:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 23:06:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-14 23:12:50]

Description was changed from

==========
Disable the old lock-screen shortcut

Disbale the shortcut but keeps the notification for another milestone.

BUG=612990
TEST=ash_unittests --gtest_filter=AcceleratorControllerTest.*
TEST=ash_unittests --gtest_filter=DeprecatedAcceleratorTester.*
==========

to

==========
Disable the old lock-screen shortcut

Disbale the shortcut but keeps the notification for another milestone.

BUG=612990
TEST=ash_unittests --gtest_filter=AcceleratorControllerTest.*
TEST=ash_unittests --gtest_filter=DeprecatedAcceleratorTester.*

Committed: https://crrev.com/1b1e927b139a713c966719345846631e0e72f308
Cr-Commit-Position: refs/heads/master@{#431946}
==========

[commit-bot: I haz the power, 2016-11-14 23:12:51]

Patchset 2 (id:??) landed as
https://crrev.com/1b1e927b139a713c966719345846631e0e72f308
Cr-Commit-Position: refs/heads/master@{#431946}