chrome/browser/ui/browser_commands.cc - Issue 2501083004: Fix View Frame Source for iframe of a file:// URL shows main frame's filename

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_commands.cc

Issue 2501083004: Fix View Frame Source for iframe of a file:// URL shows main frame's filename (Closed)

Patch Set: Excluding test in site-per-process Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_commands.cc

diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc

index e0269a8b693726b4c3e80e3dfd607876ad2fd6fd..d0066faf760efc4aaa917cd6b7becb1baf9fff6e 100644

--- a/chrome/browser/ui/browser_commands.cc

+++ b/chrome/browser/ui/browser_commands.cc

@@ -1234,6 +1234,7 @@ void ViewSource(Browser* browser,

GURL view_source_url =

GURL(content::kViewSourceScheme + std::string(":") + url.spec());

last_committed_entry->SetVirtualURL(view_source_url);

+ last_committed_entry->SetURL(url);

// Do not restore scroller position.

last_committed_entry->SetPageState(page_state.RemoveScrollOffset());